Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong display of multiline messages in the log after filtering by message level #41265

Closed
1 of 2 tasks
Pad71 opened this issue Aug 5, 2024 · 8 comments
Closed
1 of 2 tasks
Assignees
Labels
affected_version:2.9 area:core area:logging area:UI Related to UI/UX. For Frontend Developers. kind:bug This is a clearly a bug

Comments

@Pad71
Copy link

Pad71 commented Aug 5, 2024

Apache Airflow version

2.9.3

If "Other Airflow 2 version" selected, which one?

No response

What happened?

Problem displaying an error in the tab Logs in the task detail.

If the error text in the log is on multiple lines, it is displayed correctly in the basic view without filtering (see the picture)
image

But if I use filter by message level (e.g. error, see the pict) , then only the first line of the same error message is displayed. The information on the other lines for this error message is not visible (see the picture)
image

What you think should happen instead?

A multi-line message should be displayed in its entirety even after applying the message level filter

How to reproduce

Display a multi-line message (typically an error message) in the task log and then apply a filter to the ERROR level

Operating System

Linux

Versions of Apache Airflow Providers

No response

Deployment

Official Apache Airflow Helm Chart

Deployment details

No response

Anything else?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@Pad71 Pad71 added area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Aug 5, 2024
@dosubot dosubot bot added area:logging area:UI Related to UI/UX. For Frontend Developers. labels Aug 5, 2024
@Pad71
Copy link
Author

Pad71 commented Aug 5, 2024

the same problem with displaying multiline message is also when filtering to other levels (e.g. INFO etc.)

@Lee-W
Copy link
Member

Lee-W commented Aug 8, 2024

Thanks for reporting this. I just verified this happens in the latest main (45658a8963761ce8a565b481156c847e493fce67)

@Lee-W Lee-W removed the needs-triage label for new issues that we didn't triage yet label Aug 8, 2024
@Lee-W
Copy link
Member

Lee-W commented Aug 8, 2024

cc @bbovenzi

@bbovenzi
Copy link
Contributor

bbovenzi commented Sep 4, 2024

Talking with Ash about his TaskSDK work. Logs will be sent to the UI in json format so we won't need all of this regex string processing to try to add features to logs. But this is important enough to fix for 2.10.x or 2.11

@jason810496
Copy link
Contributor

Hi @Lee-W, I could try resolve this issue, could you assign to me, thanks !

@Lee-W
Copy link
Member

Lee-W commented Nov 26, 2024

Hi @Lee-W, I could try resolve this issue, could you assign to me, thanks !

Definitely, just assigned it to you 🙂

@jason810496
Copy link
Contributor

Hi @Lee-W, I think this issue can be close since the PR has been merged, thanks 🙌

@Lee-W
Copy link
Member

Lee-W commented Dec 3, 2024

Sure. Thanks for reminding me 🙂 Next time, you can mention close: #pr-number in your pr, and it'll automatically close the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected_version:2.9 area:core area:logging area:UI Related to UI/UX. For Frontend Developers. kind:bug This is a clearly a bug
Projects
None yet
Development

No branches or pull requests

5 participants