Skip to content

Commit 7eb4947

Browse files
committed
removing unnecessary conditional tests on triggers
1 parent c7dbf4c commit 7eb4947

File tree

1 file changed

+34
-36
lines changed
  • providers/microsoft/azure/src/airflow/providers/microsoft/azure/triggers

1 file changed

+34
-36
lines changed

providers/microsoft/azure/src/airflow/providers/microsoft/azure/triggers/powerbi.py

Lines changed: 34 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -285,30 +285,29 @@ def api_version(self) -> APIVersion | str:
285285

286286
async def run(self) -> AsyncIterator[TriggerEvent]:
287287
"""Make async connection to the PowerBI and polls for the list of workspace IDs."""
288-
if not self.workspace_ids:
289-
# Trigger the API to get the workspace list
290-
workspace_ids = await self.hook.get_workspace_list()
291-
292-
if workspace_ids:
293-
self.log.info("Triggered request to get workspace list.")
294-
yield TriggerEvent(
295-
{
296-
"status": "success",
297-
"message": "The workspace list get request has been successful.",
298-
"workspace_ids": workspace_ids,
299-
}
300-
)
301-
return
288+
# Trigger the API to get the workspace list
289+
workspace_ids = await self.hook.get_workspace_list()
302290

291+
if workspace_ids:
292+
self.log.info("Triggered request to get workspace list.")
303293
yield TriggerEvent(
304294
{
305-
"status": "error",
306-
"message": "Error grabbing the workspace list.",
307-
"workspace_ids": None,
295+
"status": "success",
296+
"message": "The workspace list get request has been successful.",
297+
"workspace_ids": workspace_ids,
308298
}
309299
)
310300
return
311301

302+
yield TriggerEvent(
303+
{
304+
"status": "error",
305+
"message": "Error grabbing the workspace list.",
306+
"workspace_ids": None,
307+
}
308+
)
309+
return
310+
312311

313312
class PowerBIDatasetListTrigger(BaseTrigger):
314313
"""
@@ -367,28 +366,27 @@ def api_version(self) -> APIVersion | str:
367366

368367
async def run(self) -> AsyncIterator[TriggerEvent]:
369368
"""Make async connection to the PowerBI and polls for the list of dataset IDs."""
370-
if not self.dataset_ids:
371-
# Trigger the API to get the dataset list
372-
dataset_ids = await self.hook.get_dataset_list(
373-
group_id=self.group_id,
374-
)
375-
376-
if dataset_ids:
377-
self.log.info("Triggered request to get dataset list.")
378-
yield TriggerEvent(
379-
{
380-
"status": "success",
381-
"message": f"The dataset list get request from workspace {self.group_id} has been successful.",
382-
"dataset_ids": dataset_ids,
383-
}
384-
)
385-
return
369+
# Trigger the API to get the dataset list
370+
dataset_ids = await self.hook.get_dataset_list(
371+
group_id=self.group_id,
372+
)
386373

374+
if dataset_ids:
375+
self.log.info("Triggered request to get dataset list.")
387376
yield TriggerEvent(
388377
{
389-
"status": "error",
390-
"message": "Error grabbing the dataset list.",
391-
"dataset_ids": None,
378+
"status": "success",
379+
"message": f"The dataset list get request from workspace {self.group_id} has been successful.",
380+
"dataset_ids": dataset_ids,
392381
}
393382
)
394383
return
384+
385+
yield TriggerEvent(
386+
{
387+
"status": "error",
388+
"message": "Error grabbing the dataset list.",
389+
"dataset_ids": None,
390+
}
391+
)
392+
return

0 commit comments

Comments
 (0)