-
Notifications
You must be signed in to change notification settings - Fork 268
feat(preset-chart-nvd3): migration from plugins repo #399
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/kz1ve2go1 |
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
==========================================
- Coverage 24.63% 22.25% -2.39%
==========================================
Files 239 261 +22
Lines 5747 6474 +727
Branches 581 587 +6
==========================================
+ Hits 1416 1441 +25
- Misses 4294 4996 +702
Partials 37 37
Continue to review full report at Codecov.
|
ktmud
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I like how stories for each chart type are now properly grouped.
|
@ktmud just curious what was merged and pushed to the branch? |
|
@kristw I just used GitHub's "Update branch" button. I guess it's just any change that has been merged to master after you started working on this branch. |
🏠 Internal
Migrate code and also update storybook to work with the new settings.