Add bpf target to hashers #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 21, 2025
febo
force-pushed
the
upstream-sha256-hasher
branch
2 times, most recently
from
a8a72eb to
d0724f6
Compare
Contributor
Author
|
Waiting on #408 to rebase. |
joncinque
reviewed
Oct 28, 2025
Collaborator
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks great! Just the one comment
sha256-hasher/src/lib.rs
Outdated
Comment on lines
6
to
8
| pub use { | ||
| core::mem::MaybeUninit, solana_define_syscall::definitions::sol_sha256, solana_hash::HASH_BYTES, | ||
| }; |
Collaborator
There was a problem hiding this comment.
This shouldn't be pub use, right?
Suggested change
| pub use { | |
| core::mem::MaybeUninit, solana_define_syscall::definitions::sol_sha256, solana_hash::HASH_BYTES, | |
| }; | |
| use { | |
| core::mem::MaybeUninit, solana_define_syscall::definitions::sol_sha256, solana_hash::HASH_BYTES, | |
| }; |
Contributor
Author
There was a problem hiding this comment.
Fixed. We still need to re-export the sol_sha256 syscall – solana-program references it.
febo
force-pushed
the
upstream-sha256-hasher
branch
from
66128b2 to
a82aedf
Compare
Contributor
Author
|
@joncinque Rebased and expanded the PR to include all hasher crates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The upstream compiler uses
target_arch = "bpf"when compiling tobpfel-unknown-nonetarget, while thecfgconditional compilation is currently using onlytarget_os = "solana".Solution
Add
target_arch = "bpf"along sidetarget_os = "solana".Note: Needs #389 to go first.