Undo deprecation message edit on RpcClient::get_stake_activation #2171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this PR represents a change to the public RPC API:
Thank you for keeping the RPC clients in sync with the server API @CriesofCarrots. |
t-nelson
approved these changes
Jul 18, 2024
willhickey
approved these changes
Jul 18, 2024
ruuda
referenced
this pull request
in solana-labs/solana
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The message edits in #2005 should only have gone as deep as v2.0; the
getStakeActivationRPC endpoint still exists on v1.18, although it is deprecated. This is apparently confusing to users.Summary of Changes
Revert changes to RpcClient deprecation notes. Fixup RpcRequest deprecation note.