fix(banking-stage): shutdown log spam

Author: OliverNChalk

core/src/banking_stage.rs

@@ -589,12 +589,13 @@ impl BankingStage {
         macro_rules! spawn_scheduler {
             ($scheduler:ident) => {
                 let exit = exit.clone();
+                let shutdown_signal = self.banking_shutdown_signal.clone();
                 let bank_forks = self.bank_forks.clone();
                 threads.push(
                     Builder::new()
                         .name("solBnkTxSched".to_string())
                         .spawn(move || {
-                            let scheduler_controller = SchedulerController::new(
+                            let mut scheduler_controller = SchedulerController::new(
                                 exit,
                                 scheduler_config,
                                 decision_maker,
@@ -606,7 +607,9 @@ impl BankingStage {
 
                             match scheduler_controller.run() {
                                 Ok(_) => {}
-                                Err(SchedulerError::DisconnectedRecvChannel(_)) => {}
+                                Err(SchedulerError::DisconnectedRecvChannel(_)) => {
+                                    shutdown_signal.cancel()
+                                }
                                 Err(SchedulerError::DisconnectedSendChannel(_)) => {
                                     warn!("Unexpected worker disconnect from scheduler")
                                 }

core/src/banking_stage/transaction_scheduler/scheduler_controller.rs

@@ -112,7 +112,7 @@ where
         }
     }
 
-    pub fn run(mut self) -> Result<(), SchedulerError> {
+    pub fn run(&mut self) -> Result<(), SchedulerError> {
         let mut most_recent_leader_slot = None;
         let mut cost_pacer = None;
 
@@ -634,7 +634,7 @@ mod tests {
     #[test]
     #[should_panic(expected = "batch id 0 is not being tracked")]
     fn test_unexpected_batch_id() {
-        let (test_frame, scheduler_controller) =
+        let (test_frame, mut scheduler_controller) =
             create_test_frame(1, test_create_transaction_view_receive_and_buffer);
         let TestFrame {
             finished_consume_work_sender,