Add support for Mailtrap #406
Conversation
| test_api_url += "/" | ||
| self.test_api_url = test_api_url | ||
|
|
||
| bulk_api_url = get_anymail_setting( |
There was a problem hiding this comment.
I haven't quite determined how Backends should handle bulk emails, but it also does not appear that Mailtrap's APIs are any different for their "Email sending" vs "Bulk email" APIs https://api-docs.mailtrap.io/docs/mailtrap-api-docs/.
Maybe this self.bulk_api_url is unnecessary, and it should be up to the user to configure which API url to use via self.api_url?
| ) | ||
|
|
||
| # Not the best status reporting. Mailtrap only says that the order of message-ids will be in this order (but JSON is unordered?) | ||
| recipient_status_order = [*message.to, *message.cc, *message.bcc] |
There was a problem hiding this comment.
Mailtrap's status reporting is pretty poor, and I'm not even sure if this will work consistently, given that it is depending on ORDERED JSON responses 🤦
cahna
force-pushed
the
mailtrap
branch
4 times, most recently
from
c3b2c2d
to
8c44826
Compare
|
Thanks for this! It looks pretty good at first glance; I'll try to take a closer look later this week.
Missing inbound support is not unusual; it's fine to just ignore it. Reply-to is a little surprising. Some ESPs require handling this as an extra header. (I haven't had a chance to look at Mailtrap's docs.)
What's going wrong? (In the contributing docs, I notice the "test a representative combination of Python and Django versions" command is outdated—the current version should be |
Hi, and thanks for creating such a great library! I would love to have Mailtrap support, and I figured it would be helpful if I started on that. This is very much a work-in-progress, as I'm still trying to understand how to handle all of the features that Anymail provides, and whether those features are supported by Mailtrap. I have already caught at least one category of features that Mailtrap does not support: inbound emails and reply-to.
If anyone would be willing to provide some feedback on what I have, and any guidance on how to continue, I would appreciate it, and I will be sure to add tests and documentation.
I am also having trouble getting local builds and tests to work, or I would have started on adding tests. If someone could point me in the direction of minimal steps to get tests working on Ubuntu, I would appreciate it. (The contributing docs don't seem to work for me).
Cheers