Skip to content

Commit 6e715cb

Browse files
committed
DATAJDBC-427 - Polishing.
Used isEqual assertions instead of directly calling equals. Code formatting.
1 parent cef4152 commit 6e715cb

File tree

2 files changed

+33
-27
lines changed

2 files changed

+33
-27
lines changed

spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/mapping/AggregateReference.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,5 +61,4 @@ public ID getId() {
6161
return id;
6262
}
6363
}
64-
6564
}

spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/mapping/IdOnlyAggregateReferenceTest.java

Lines changed: 33 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -11,30 +11,37 @@
1111
* @author Myeonghyeon Lee
1212
*/
1313
public class IdOnlyAggregateReferenceTest {
14-
@Test // DATAJDBC-427
15-
public void equals() {
16-
AggregateReference<DummyEntity, String> reference1 = AggregateReference.to("1");
17-
AggregateReference<DummyEntity, String> reference2 = AggregateReference.to("1");
18-
assertThat(reference1.equals(reference2)).isTrue();
19-
assertThat(reference2.equals(reference1)).isTrue();
20-
}
21-
22-
@Test // DATAJDBC-427
23-
public void equalsFalse() {
24-
AggregateReference<DummyEntity, String> reference1 = AggregateReference.to("1");
25-
AggregateReference<DummyEntity, String> reference2 = AggregateReference.to("2");
26-
assertThat(reference1.equals(reference2)).isFalse();
27-
assertThat(reference2.equals(reference1)).isFalse();
28-
}
29-
30-
@Test // DATAJDBC-427
31-
public void hashCodeTest() {
32-
AggregateReference<DummyEntity, String> reference1 = AggregateReference.to("1");
33-
AggregateReference<DummyEntity, String> reference2 = AggregateReference.to("1");
34-
assertThat(reference1.hashCode()).isEqualTo(reference2.hashCode());
35-
}
36-
37-
private static class DummyEntity {
38-
private String id;
39-
}
14+
15+
@Test // DATAJDBC-427
16+
public void equals() {
17+
18+
AggregateReference<DummyEntity, String> reference1 = AggregateReference.to("1");
19+
AggregateReference<DummyEntity, String> reference2 = AggregateReference.to("1");
20+
21+
assertThat(reference1).isEqualTo(reference2);
22+
assertThat(reference2).isEqualTo(reference1);
23+
}
24+
25+
@Test // DATAJDBC-427
26+
public void equalsFalse() {
27+
28+
AggregateReference<DummyEntity, String> reference1 = AggregateReference.to("1");
29+
AggregateReference<DummyEntity, String> reference2 = AggregateReference.to("2");
30+
31+
assertThat(reference1).isNotEqualTo(reference2);
32+
assertThat(reference2).isNotEqualTo(reference1);
33+
}
34+
35+
@Test // DATAJDBC-427
36+
public void hashCodeTest() {
37+
38+
AggregateReference<DummyEntity, String> reference1 = AggregateReference.to("1");
39+
AggregateReference<DummyEntity, String> reference2 = AggregateReference.to("1");
40+
41+
assertThat(reference1.hashCode()).isEqualTo(reference2.hashCode());
42+
}
43+
44+
private static class DummyEntity {
45+
private String id;
46+
}
4047
}

0 commit comments

Comments
 (0)