-
-
Notifications
You must be signed in to change notification settings - Fork 22.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: allow to customize wakatime data range #874
chore: allow to customize wakatime data range #874
Conversation
@muety is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report
@@ Coverage Diff @@
## master #874 +/- ##
=======================================
Coverage 93.97% 93.98%
=======================================
Files 22 22
Lines 681 682 +1
Branches 190 191 +1
=======================================
+ Hits 640 641 +1
Misses 37 37
Partials 4 4
Continue to review full report at Codecov.
|
Could somebody please take a look at this? |
This looks good @muety can you add the |
docs: add wakatime section to german readme
Sure, it's done! |
Btw, how am I supposed to resolve the merge conflict? Rebase onto |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/github-readme-stats-team/github-readme-stats/Be7dfCF1ZYvJWxLeeye2tEZhcYxf |
This looks good! thanks @muety |
* chore: allow to customize wakatime data range * docs: document wakatime range parameter docs: add wakatime section to german readme Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com>
PR #871 changed the WakaTime fetcher in a way that it always requests data for whatever range the user has set as "Default Range" in WakaTime. However, chances are that a user may want a deviating range for her readme cards. Or she wants different ranges for different readmes in different repos.
Also, it makes behavior more predictable when using third-party sevice like Wakapi, that don't have inherent support for configurable "default ranges".
This PR allows to pass another, optional parameter to the WakaTime card to explicitly request a certain range.