Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo card hide border #488

Merged
merged 6 commits into from
Sep 24, 2020
Merged

Repo card hide border #488

merged 6 commits into from
Sep 24, 2020

Conversation

Bas950
Copy link
Contributor

@Bas950 Bas950 commented Sep 24, 2020

As requseted in #480
Making different PRs for the new features

/api/pin/?username=USER&repo=REPO
image
/api/pin/?username=USER&repo=REPO&hide_border=true
image
(Hard to see... but it is removed.)

Will make PRs for the other features after this one is merged, otherwise we will get merge conflicts.

@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #488 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #488      +/-   ##
==========================================
+ Coverage   92.36%   92.37%   +0.01%     
==========================================
  Files          20       20              
  Lines         576      577       +1     
  Branches      159      160       +1     
==========================================
+ Hits          532      533       +1     
  Misses         38       38              
  Partials        6        6              
Impacted Files Coverage Δ
api/index.js 94.11% <ø> (ø)
api/pin.js 91.30% <ø> (ø)
api/top-langs.js 94.11% <ø> (ø)
src/cards/wakatime-card.js 70.00% <ø> (ø)
src/common/retryer.js 72.22% <ø> (ø)
src/common/utils.js 97.36% <ø> (ø)
src/fetchers/repo-fetcher.js 95.83% <ø> (ø)
src/fetchers/top-languages-fetcher.js 100.00% <ø> (ø)
src/fetchers/wakatime-fetcher.js 100.00% <ø> (ø)
themes/index.js 100.00% <ø> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 278d6a1...2d69bc2. Read the comment docs.

@github-actions github-actions bot added the themes Feature, Enhancement, Fixes related to themes. label Sep 24, 2020
@anuraghazra
Copy link
Owner

Theme preview (bot)
Cannot create theme preview

@anuraghazra anuraghazra added enhancement New feature or request. lang-card Issues related to the language card. and removed themes Feature, Enhancement, Fixes related to themes. labels Sep 24, 2020
@anuraghazra
Copy link
Owner

Theme preview (bot)
Cannot create theme preview

@anuraghazra
Copy link
Owner

Thanks @Bas950!

@anuraghazra anuraghazra merged commit 8aea1e3 into anuraghazra:master Sep 24, 2020
@Bas950 Bas950 deleted the repo-card-hide-border branch September 24, 2020 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. lang-card Issues related to the language card.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants