Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd error message when an URL parameter is passed multiple times #3055

Open
sigma67 opened this issue Aug 8, 2023 · 4 comments · May be fixed by #3393
Open

Odd error message when an URL parameter is passed multiple times #3055

sigma67 opened this issue Aug 8, 2023 · 4 comments · May be fixed by #3393
Assignees
Labels
bug Something isn't working. feature

Comments

@sigma67
Copy link

sigma67 commented Aug 8, 2023

Describe the bug

When creating my own deployment, by mistake I passed an URL parameter twice. This can happen easily due to the number of configuration parameters.

In this example, I passed hide twice to top-langs.

I was greeted with the error message str.split is not a function.

Expected behavior

github-readme-stats should perform basic validation and provide a decent error message. This would also prevent unnecessary issues created on GitHub.

Screenshots / Live demo link

No response

Additional context

Thanks for creating this great project!

@sigma67 sigma67 added the bug Something isn't working. label Aug 8, 2023
@rickstaa
Copy link
Collaborator

rickstaa commented Aug 13, 2023

@sigma67, thanks for the bug report. This is related to #2737. @qwerty541 should we handle this behavoir internally?

@qwerty541
Copy link
Collaborator

@sigma67, thanks for the bug report. This is related to #2737. @qwerty541 should we handle this behavoir internally?

@rickstaa We should not resolve type conflicts of query parameters internally, but i agree with @sigma67 that we should show adequate error message to user. I'll try to make a pull request soon to fix this.

@airwakz
Copy link

airwakz commented Oct 15, 2023

@qwerty541 can i try to solve this issue

@qwerty541
Copy link
Collaborator

@qwerty541 can i try to solve this issue

@airwakz Thanks for your interest, but recently i have opened a pull request which will solve this #3393

@qwerty541 qwerty541 self-assigned this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. feature
Projects
None yet
4 participants