Skip to content

fix(chord): 修复和弦图 state 设置不生效 #2633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 15, 2021
Merged

fix(chord): 修复和弦图 state 设置不生效 #2633

merged 2 commits into from
Jun 15, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Jun 12, 2021 •
edited by Angelii
Loading

PR includes

Screenshot

Before After
❌ ✅

@visiky
fix(chord): 修复和弦图 state 设置不生效
e93d07a 
同 dual-axes 存在多view的情况
@github-actions
Copy link
Contributor

github-actions bot commented Jun 12, 2021 •
edited
Loading

🎊 PR Preview ee3d98c has been successfully built and deployed to https://antvis-G2Plot-preview-pr-2633.surge.sh?type=diff&date=2021-06-13

🕐 Build time: 87.465s

🤖 By surge-preview

@coveralls
Copy link

coveralls commented Jun 12, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 932515926

  • 21 of 21 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 96.09%
Totals Coverage Status
Change from base Build 930578592: 0.03%
Covered Lines: 5999
Relevant Lines: 6092
💛 - Coveralls

@visiky visiky requested a review from hustcc June 13, 2021 04:21
@visiky visiky merged commit 1b3b07a into master Jun 15, 2021
@visiky visiky deleted the fix-chord-state branch June 15, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

【和弦图】若干诉求
3 participants
@visiky @coveralls @hustcc