Skip to content

feat(sankey): remove the circle data in sankey #2178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 7, 2021
Merged

feat(sankey): remove the circle data in sankey #2178

merged 4 commits into from
Jan 7, 2021

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Jan 6, 2021

PR includes

  • remove circle data of sankey
  • add / modify test cases

Screenshot

Before After
❌ ✅

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2021 •
edited
Loading

😭 Deploy PR Preview 9d195d4 failed. Build logs

🤖 By surge-preview

@coveralls
Copy link

coveralls commented Jan 6, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 466162876

  • 27 of 27 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 96.84%
Totals Coverage Status
Change from base Build 465422309: 0.02%
Covered Lines: 4521
Relevant Lines: 4559
💛 - Coveralls

@hustcc hustcc requested a review from visiky January 6, 2021 08:54
YiSiWang
YiSiWang reviewed Jan 6, 2021
View reviewed changes
@visiky visiky merged commit e248c8e into master Jan 7, 2021
@visiky visiky deleted the fix-sankey-circle branch January 7, 2021 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visiky visiky visiky approved these changes

+1 more reviewer

@YiSiWang YiSiWang YiSiWang left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hustcc @coveralls @visiky @YiSiWang