Skip to content

fix: funnel undefined render #2150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2020
Merged

fix: funnel undefined render #2150

merged 1 commit into from
Dec 28, 2020

Conversation

liuzhenying
Copy link
Member

PR includes

  • fixed #0
  • add / modify test cases
  • documents, demos

Screenshot

Before After
❌ 屏幕快照 2020-12-28 09 58 42
值为 undefined 时，图形合理渲染

@liuzhenying liuzhenying requested a review from hustcc December 28, 2020 02:00
@github-actions
Copy link
Contributor

github-actions bot commented Dec 28, 2020 •
edited
Loading

😭 Deploy PR Preview b4772d3 failed. Build logs

🤖 By surge-preview

@coveralls
Copy link

Pull Request Test Coverage Report for Build 447982962

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 96.766%
Totals Coverage Status
Change from base Build 442312124: 0.02%
Covered Lines: 4373
Relevant Lines: 4411
💛 - Coveralls

@hustcc hustcc merged commit b443dbd into master Dec 28, 2020
@hustcc hustcc deleted the fix/funnel-undefined branch December 28, 2020 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liuzhenying @coveralls @hustcc