Skip to content

feat(waterfall): 初始化瀑布图 #1697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 12, 2020
Merged

feat(waterfall): 初始化瀑布图 #1697

merged 13 commits into from
Oct 12, 2020

Conversation

visiky
Copy link
Member

@visiky visiky commented Oct 9, 2020 •
edited
Loading

preview
image image image

checklist

  • draw
  • types define
  • custom register shape
  • tooltip (默认展示 差值，即 yField 对应的数据，支持 customContent)
  • legend (内置 legend，同时增加自定义图例的 demo)
    • custom legend interaction(暂缓)
  • label (提供 labelDataMode，支持配置展示「数据绝对值」)
    是否改名为 dataLabelsMode (竞品使用 label.dataMode 的配置)
  • testcases
  • docs
    • api
    • manual docs(暂缓)

@auto-add-label auto-add-label bot added the WIP label Oct 9, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2020 •
edited
Loading

🎊 PR Preview 9156861 has been successfully built and deployed to https://antvis-G2Plot-preview-pr-1697.surge.sh

🕐 Build time: 552.211s

🤖 By surge-preview

@lgtm-com
Copy link

lgtm-com bot commented Oct 9, 2020

This pull request introduces 1 alert when merging bf75ea9 into 9c10ebe - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@visiky visiky requested a review from hustcc October 11, 2020 10:05
hustcc
hustcc reviewed Oct 11, 2020
View reviewed changes
hustcc
hustcc reviewed Oct 11, 2020
View reviewed changes
hustcc
hustcc reviewed Oct 11, 2020
View reviewed changes
hustcc
hustcc reviewed Oct 11, 2020
View reviewed changes
hustcc
hustcc reviewed Oct 11, 2020
View reviewed changes
hustcc
hustcc reviewed Oct 11, 2020
View reviewed changes
hustcc
hustcc reviewed Oct 11, 2020
View reviewed changes
visiky added 9 commits October 11, 2020 22:57
@visiky
feat(waterfall): 初始化瀑布图
beaa7a5 
**checklist**

- [x] draw
- [x] types define
- [x] custom register shape
- [ ] tooltip
- [ ] legend
- [ ] testcases
- [ ] others, such as: diff-label
@visiky
refactor(waterfall-utils): 修改瀑布图处理数据方法 & 添加测例
0e069bc
@visiky
feat(waterfall-label): 完善 label, 提供 labelDataMode
8273462 
labelDataMode 指定标签展示绝对值还是相对差值
@visiky
feat(waterfall-demo): 完善基础 demo & 优化默认配置
e22f979
@visiky
fix(waterfall-testcases): 修复测试用例
a244123
@visiky
fix(waterfalll-shape): 修复 shape 连接线异常
88a9e0d
@visiky
feat(waterfall): 瀑布图各种补全
dc0f57a 
- [x] process data
- [x] legend
- [x] color, support config `risingFill` and `fallingFill`
- [x] defaultOptions & demo
@visiky
feat(waterfall-testcases): 增加测试用例
171c2c3 
- [ ] base
- [ ] label
- [x] annotaiton
- [x] axis
- [x] style
- [x] shape
@visiky
feat(mapping): 添加 rawFields 参数, 增强回调参数数据
10ee7eb
@visiky visiky changed the title wip: feat(waterfall): 初始化瀑布图 feat(waterfall): 初始化瀑布图 Oct 12, 2020
@auto-add-label auto-add-label bot added the enhancement New feature or request label Oct 12, 2020
@hustcc hustcc self-requested a review October 12, 2020 03:03
hustcc
hustcc reviewed Oct 12, 2020
View reviewed changes
hustcc
hustcc reviewed Oct 12, 2020
View reviewed changes
@visiky visiky force-pushed the waterfall branch 2 times, most recently from 6c92602 to 1d96cb8 Compare October 12, 2020 03:42
@visiky visiky merged commit 9156861 into master Oct 12, 2020
@visiky visiky deleted the waterfall branch October 12, 2020 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request PR: merged WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@visiky @hustcc