feat: 新改动子弹图和新增docs #1545
Merged
feat: 新改动子弹图和新增docs #1545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
增加histogram的文档
visiky
reviewed
Sep 9, 2020
examples/bullet/basic/API.en.md
Outdated
|
|
||
| 默认配置： 无 | ||
|
|
||
| ### bulletLabel |
There was a problem hiding this comment.
😳 是为了统一的那个bulletStyle类似 尴尬了 觉得不合适的我等等可以修复掉
There was a problem hiding this comment.
看看好不好改，如果不好改先合并了，然后下一个分支写 demo 的时候改掉吧。 @arcsin1
hustcc
reviewed
Sep 9, 2020
src/plots/bullet/utils.ts
Outdated
| @@ -1,41 +1,41 @@ | |||
| import { BulletOptions, BulletData } from './types'; | |||
| import { BulletOptions } from './types'; | |||
|
|
|||
| type TransFormData = { | |||
There was a problem hiding this comment.
nit: TransformData。Transform 是一个单词
hustcc
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
基于上个版本：