fix: enabling snapline plugin selecting and moving cells bug #4493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…translateby是node2时，导致node2和组合在一起的node3移动错乱，并且node1移动错误的bug
hustcc
reviewed
Aug 12, 2025
| @@ -573,7 +573,11 @@ export class SelectionImpl extends View<SelectionImpl.EventArgs> { | |||
| if (otherOptions && otherOptions.translateBy) { | |||
| const currentCell = this.graph.getCellById(otherOptions.translateBy) | |||
| if (currentCell) { | |||
| map[currentCell.id] = true | |||
| // 问题：开启snapline后，当我们框选圆形组件、node2矩形组件（node2中有一个node3被embedding时）,translateby是node2时，导致node2和组合在一起的node3移动错乱，并且node1移动错误的bug | |||
There was a problem hiding this comment.
map[currentCell.id] = true
@wqgs2004214 这行代码知道是用来干啥的嘛？一定是特意需要这么做的，直接删了会带其他更多的问题吧？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…translateby是node2时，导致node2和组合在一起的node3移动错乱，并且node1移动错误的bug
Description
fix #4491
Motivation and Context
Types of changes
Self Check before Merge