Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misspelled type name in source code #482

Open
maxott opened this issue Apr 20, 2023 · 1 comment
Open

Misspelled type name in source code #482

maxott opened this issue Apr 20, 2023 · 1 comment
Labels
bug Something isn't working Typing Error

Comments

@maxott
Copy link

maxott commented Apr 20, 2023

Describe the bug

Apparent typo in source code

https://github.com/antvis/Graphin/blob/master/packages/graphin/src/behaviors/ZoomCanvas.tsx
export type IDragCanvasProps = Partial<typeof defaultConfig>;

should most likely be:

export type IZoomCanvasProps = Partial<typeof defaultConfig>;

Your Example Website or App

none - just starting

Steps to Reproduce the Bug or Issue

See above

Expected behavior

See above.

In fact, I'm not sure if those types are directly exposed. Right now I access them directly:

import { IDragCanvasProps as IZoomCanasProps } from '@antv/graphin/lib/behaviors/ZoomCanvas'

Screenshots or Videos

No response

Platform

Any - just source code issue

Additional context

No response

@pomelo-nwu
Copy link
Member

@maxott Yes, your finding is right. Could you give me a PR to fix it? Thank you very much

@pomelo-nwu pomelo-nwu added bug Something isn't working Typing Error labels May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Typing Error
Projects
Status: No status
Development

No branches or pull requests

2 participants