Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimap is not attached/relative to the graph #470

Open
romulorod opened this issue Feb 16, 2023 · 1 comment
Open

Minimap is not attached/relative to the graph #470

romulorod opened this issue Feb 16, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@romulorod
Copy link

romulorod commented Feb 16, 2023

Describe the bug

Whenever rendering multiple graphs and using minimaps for each one of them, the minimaps gets "lost", specially if passing options props to it because that would trigger the useEffect inside the component to render which destroys and re-renders the minimap, and what that causes is that both minimaps are rendered together instead of each minimap being "inside" its own graph.

Your Example Website or App

https://codesandbox.io/s/funny-montalcini-v89qno?file=/App.tsx

Steps to Reproduce the Bug or Issue

This is a very small example of what I'm talking about because I couldn't reproduce everything but you can get the sense of it from that code pen.

Expected behavior

Each minimap would be "attached" to its own graph

Screenshots or Videos

Expected Behavior, happens before I update the component props, as including another view.
Expected Behavior

Bug after updating props to include another view.
Buggy after component update props

Platform

  • OS: [Linux]
  • Browser: [Chrome, Edge]

Additional context

It happens after a component update props but since I can render from 1 to 4 charts in the same component, this should happen and the minimap should still recognize its parent graph and stick to it.

I'm not sure yet how to handle / solve this so I'd appreciate any help here, thanks in advance!!

@pomelo-nwu pomelo-nwu added the bug Something isn't working label May 28, 2023
@pomelo-nwu
Copy link
Member

@romulorod https://github.com/antvis/Graphin/blob/master/packages/graphin/src/components/MiniMap/index.tsx#LL52C18-L52C30 Seems to be the problem here, we will fix it as soon as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In Progress
Development

No branches or pull requests

3 participants