feat: add graphin props setting to sdk config #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Seventysevendays
commented
Apr 12, 2024
Seventysevendays
commented
- add graphin props setting to sdk config
Aarebecca
reviewed
Apr 12, 2024
package.json
Outdated
| "webpack-cli": "^5.0.0" | ||
| } | ||
| }, | ||
| "version": "0.0.1" |
lxfu1
reviewed
Apr 12, 2024
| const graphinRef = React.useRef<null | Graphin>(null); | ||
| // @ts-ignore | ||
| const { children, assets, id, services, config, locales } = props; | ||
| const { children, assets, id, services, config, locales, grapinProps } = props; |
Member
There was a problem hiding this comment.
感觉不用新增一个 grapinProps 吧，和 layout 这类配置放一起就好
Collaborator
Author
There was a problem hiding this comment.
感觉不用新增一个 grapinProps 吧，和 layout 这类配置放一起就好
animate、style、containerStyle... 等等一堆配置，后边这样一个个加进来么？
Seventysevendays
force-pushed
the
feat-sdk-xx
branch
from
239907f to
edb9707
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.