-
Notifications
You must be signed in to change notification settings - Fork 1.6k
chores: 删除无用字段 CollapseExpandNodeOptions.align & 补充测试 behavior-expand-collapse-node collapsed初始状态 #7262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v5
Are you sure you want to change the base?
Conversation
|
@HawtinZeng |
d5c598c to
a8dd349
Compare
|
文件结束符改成LF了 |
|
@HawtinZeng 修复一下 ci 吧~ |
g6-extension-react本地跑pnpm run test能通过,ci不通过
|
|
CI通过了,可以合进主分支了 |
|
@HawtinZeng 最好是添加一个额外的测试用例 |
|
我觉得用不着,因为最开始behavior-expand-collapse-node的测试数据有个点就是collapsed,但我跑测试通过不了,我就把这个collapsed状态删掉了,后面有人提了一个collapsed的bug,我这个时候才找到对应的解决办法。需要改一下原来的图配置。所以这个测试用例并没有发生什么改变。只是图配置变了,图配置也不影响这个用例中的其它功能。 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v5 #7262 +/- ##
==========================================
- Coverage 95.59% 95.47% -0.12%
==========================================
Files 188 188
Lines 9888 9905 +17
Branches 2134 2132 -2
==========================================
+ Hits 9452 9457 +5
- Misses 436 448 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
本次 PR 主要移除了 CollapseExpandNodeOptions 中已废弃的 align 字段,并更新了相关的行为、测试和文档。此外,还补充了 behavior-expand-collapse-node 在 collapsed 初始状态下的测试用例。代码变更整体上是正确的,但有几点建议:
- 在
runtime/behavior.ts中,对已销毁元素的事件处理逻辑被削弱,建议恢复。 utils/element.ts中的setAttributes函数存在代码重复,可以进行重构以提高可维护性。- API 文档中
CollapseExpandNodeOptions的类型定义没有完全更新,需要移除align字段。
这些修改将有助于提高代码的健壮性和可维护性。
…-collapse-node/combo collapsed初始状态
2d53215 to
3723fbc
Compare

No description provided.