Skip to content

fix(venn): fix venn color option type compatibility #3015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2021
Merged

fix(venn): fix venn color option type compatibility #3015

merged 1 commit into from
Dec 9, 2021

Conversation

FOWind
Copy link
Contributor

@FOWind FOWind commented Dec 9, 2021 •
edited
Loading

PR includes

  • fixed #0
  • add / modify test cases
  • documents, demos

Screenshot

Before After
❌ ✅

image

@FOWind FOWind mentioned this pull request Dec 9, 2021
Closed
visiky
visiky approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@visiky visiky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG；

@visiky visiky linked an issue Dec 9, 2021 that may be closed by this pull request
🤔 [QUESTION]Interface 'VennOptions' incorrectly extends interface 'Options' #3006
Closed
@visiky visiky merged commit 4364df5 into antvis:master Dec 9, 2021
@FOWind FOWind deleted the fix/venn-options branch March 1, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visiky visiky visiky approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🤔 [QUESTION]Interface 'VennOptions' incorrectly extends interface 'Options'
2 participants
@FOWind @visiky