advicesForChart & advicesForGraph

[chenluli]

AVA/packages/chart-advisor/src/advisor/index.ts

Lines 108 to 117 in e842d39

	const graphAdvices = this.advicesForGraph(params as GraphAdviseParams);
	if (this.shouldRecommendGraph(data, options)) {
	adviceResult = graphAdvices;
	// todo
	// advices = graphAdvices.concat(chartAdvices)
	} else {
	const chartAdvices = this.advicesForChart(params as ChartAdviseParams);
	// Otherwise, higher priority for statistical charts
	adviceResult = (chartAdvices as Advice[]).concat(graphAdvices) as Advice[];
	}

这里本来是想 const chartAdvices = this.advicesForChart(params as ChartAdviseParams); 也在条件外面的，这样如果更推荐graph 就把 chartAdvices 放在数组后面（希望所有数据进来 chart 和 graph 两个推荐路径都尝试一下）；但当时传入树形结构数据初始化DataFrame会因为有嵌套数组报错，所以判断为 graph 了就没有走 advicesForChart 了

后面DataFrame 好像修了这个问题，我觉得现在可以都放在条件判断之外，两个路径都走