Replace 'Release' with 'Antrea' in the release title #5742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnqn
reviewed
Nov 22, 2023
hack/release/draft-release.sh
Outdated
| @@ -84,7 +84,7 @@ release="${release#v}" | |||
| major_minor_number="${release%.*}" | |||
| branch="release-${major_minor_number}" | |||
| tag="v${release}" | |||
| title="Release $tag" | |||
| title="Antrea $tag" | |||
There was a problem hiding this comment.
Can we get the project name from $repo so it can be easily reused by other projects?
project=${repo##*/}
title="${project^} $tag"
Replace 'Release' with 'Antrea' in the release title, so we can have a release name like `Release Antrea v1.14.1` instead of `Release Release v1.14.1` in the github release link preview. Signed-off-by: Lan Luo <luola@vmware.com>
luolanzone
force-pushed
the
update-release-title
branch
from
3bcda40
to
ecfa943
Compare
tnqn
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
LGTM.
@antoninbas I guess there is no special reason why we used "Release vX.Y,X" as the title?
antoninbas
approved these changes
Nov 22, 2023
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace 'Release' with 'Antrea' in the release title, so we can have a release name like
Release Antrea v1.14.1instead ofRelease Release v1.14.1in the github release link preview.