Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated upgrade support for Jenkins kind clusters #5290

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

KMAnju-2021
Copy link
Contributor

@KMAnju-2021 KMAnju-2021 commented Jul 21, 2023

Closes #4960
Signed-off-by: KMAnju-2021 km074btcse18@igdtuw.ac.in

Updated the Jenkins script and GitHub workflow (kind.yaml) to support automatic upgrades for kind.

@KMAnju-2021 KMAnju-2021 marked this pull request as draft July 21, 2023 04:49
ci/kind/kind-upgrade.sh Outdated Show resolved Hide resolved
ci/kind/kind-upgrade.sh Outdated Show resolved Hide resolved
ci/kind/kind-upgrade.sh Outdated Show resolved Hide resolved
ci/kind/kind-upgrade.sh Outdated Show resolved Hide resolved
ci/kind/kind-upgrade.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@rajnkamr rajnkamr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz address review comment

ci/kind/kind-upgrade.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@jainpulkit22 jainpulkit22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few Suggestions.

ci/kind/kind-upgrade.sh Outdated Show resolved Hide resolved
ci/kind/kind-upgrade.sh Outdated Show resolved Hide resolved
ci/kind/kind-upgrade.sh Outdated Show resolved Hide resolved
ci/kind/kind-upgrade.sh Outdated Show resolved Hide resolved
ci/kind/kind-upgrade.sh Outdated Show resolved Hide resolved
@KMAnju-2021 KMAnju-2021 force-pushed the kind-auto-upgrade branch 2 times, most recently from ba467f3 to 886df3d Compare August 16, 2023 08:17
Copy link
Contributor

@edwardbadboy edwardbadboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments.

ci/kind/kind-upgrade.sh Outdated Show resolved Hide resolved
ci/kind/kind-upgrade.sh Outdated Show resolved Hide resolved
ci/kind/kind-upgrade.sh Outdated Show resolved Hide resolved
@KMAnju-2021 KMAnju-2021 force-pushed the kind-auto-upgrade branch 3 times, most recently from 15cebb0 to 962f7de Compare September 5, 2023 09:00
edwardbadboy
edwardbadboy previously approved these changes Sep 14, 2023
ci/kind/kind-upgrade.sh Outdated Show resolved Hide resolved
ci/kind/kind-upgrade.sh Outdated Show resolved Hide resolved
@XinShuYang
Copy link
Contributor

Please update commit message and PR description.

edwardbadboy
edwardbadboy previously approved these changes Nov 15, 2023
.github/workflows/conformance.yml Outdated Show resolved Hide resolved
ci/kind/kind-upgrade.sh Outdated Show resolved Hide resolved
ci/kind/kind-install.sh Outdated Show resolved Hide resolved
@KMAnju-2021 KMAnju-2021 force-pushed the kind-auto-upgrade branch 2 times, most recently from 4544fc4 to 0980090 Compare November 17, 2023 12:28
ci/kind/kind-install.sh Outdated Show resolved Hide resolved
ci/kind/kind-install.sh Outdated Show resolved Hide resolved
Signed-off-by: KMAnju-2021 <km074btcse18@igdtuw.ac.in>
@antoninbas
Copy link
Contributor

@KMAnju-2021 any Jenkins test that we need to run before merging this?

@KMAnju-2021
Copy link
Contributor Author

@KMAnju-2021 any Jenkins test that we need to run before merging this?

yes, I triggered that, will let you know once it passed.

@KMAnju-2021
Copy link
Contributor Author

/test-kind-networkpolicy

@KMAnju-2021
Copy link
Contributor Author

/test-kind-conformance

@KMAnju-2021
Copy link
Contributor Author

@antoninbas jenkins tests are passed, thanks!

@antoninbas antoninbas merged commit ed362ce into antrea-io:main Nov 20, 2023
45 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automated Upgrade Support for Jenkins kind Clusters
8 participants