Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/Microsoft/hcsshim from 0.9 to 0.11 #5611

Closed
antoninbas opened this issue Oct 24, 2023 · 2 comments
Closed

Bump github.com/Microsoft/hcsshim from 0.9 to 0.11 #5611

antoninbas opened this issue Oct 24, 2023 · 2 comments
Labels
area/dependency Issues or PRs related to dependency changes. kind/task Categorizes issue or PR as related to a routine task that needs to be performed

Comments

@antoninbas
Copy link
Contributor

I think we should look into updating this dependency. It seems lots of changes went into https://github.com/microsoft/hcsshim/releases/tag/v0.11.0. We may benefit from more up-to-date transitive dependencies as well (see the large go.sum diff in https://github.com/antrea-io/antrea/pull/5594/files).

I think we may want to update the dependency manually here instead of relying on Dependabot, to review the main changes that went into v0.11, and decide whether anything needs to change on the Antrea side.

The latest patch release for 0.11 is 0.11.2, at the time of opening this issue.

cc @luolanzone @wenyingd

@antoninbas antoninbas added kind/task Categorizes issue or PR as related to a routine task that needs to be performed area/dependency Issues or PRs related to dependency changes. labels Oct 24, 2023
@antoninbas antoninbas added this to the Antrea v1.15 release milestone Oct 24, 2023
XinShuYang added a commit to XinShuYang/antrea that referenced this issue Nov 14, 2023
For antrea-io#5611

Bumps [github.com/Microsoft/hcsshim](https://github.com/Microsoft/hcsshim) from 0.9.10 to 0.11.4.

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
XinShuYang added a commit to XinShuYang/antrea that referenced this issue Nov 14, 2023
For antrea-io#5611

Bumps [github.com/Microsoft/hcsshim](https://github.com/Microsoft/hcsshim) from 0.9.10 to 0.11.4.

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
XinShuYang added a commit to XinShuYang/antrea that referenced this issue Nov 14, 2023
For antrea-io#5611

Bumps [github.com/Microsoft/hcsshim](https://github.com/Microsoft/hcsshim) from 0.9.10 to 0.11.4.

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
XinShuYang added a commit to XinShuYang/antrea that referenced this issue Nov 15, 2023
For antrea-io#5611

Bumps [github.com/Microsoft/hcsshim](https://github.com/Microsoft/hcsshim) from 0.9.10 to 0.11.4.

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
XinShuYang added a commit to XinShuYang/antrea that referenced this issue Nov 15, 2023
For antrea-io#5611

Bumps [github.com/Microsoft/hcsshim](https://github.com/Microsoft/hcsshim) from 0.9.10 to 0.11.4.

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
XinShuYang added a commit to XinShuYang/antrea that referenced this issue Nov 15, 2023
For antrea-io#5611

Bumps [github.com/Microsoft/hcsshim](https://github.com/Microsoft/hcsshim) from 0.9.10 to 0.11.4.

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
XinShuYang added a commit to XinShuYang/antrea that referenced this issue Nov 16, 2023
For antrea-io#5611

Bumps [github.com/Microsoft/hcsshim](https://github.com/Microsoft/hcsshim) from 0.9.10 to 0.11.4.

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
XinShuYang added a commit to XinShuYang/antrea that referenced this issue Nov 16, 2023
For antrea-io#5611

Bumps [github.com/Microsoft/hcsshim](https://github.com/Microsoft/hcsshim) from 0.9.10 to 0.11.4.

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
XinShuYang added a commit to XinShuYang/antrea that referenced this issue Nov 16, 2023
For antrea-io#5611

Bumps [github.com/Microsoft/hcsshim](https://github.com/Microsoft/hcsshim) from 0.9.10 to 0.11.4.

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
XinShuYang added a commit to XinShuYang/antrea that referenced this issue Nov 16, 2023
For antrea-io#5611

Bumps [github.com/Microsoft/hcsshim](https://github.com/Microsoft/hcsshim) from 0.9.10 to 0.11.4.

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
XinShuYang added a commit to XinShuYang/antrea that referenced this issue Nov 16, 2023
For antrea-io#5611

Bumps [github.com/Microsoft/hcsshim](https://github.com/Microsoft/hcsshim) from 0.9.10 to 0.11.4.

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
@XinShuYang
Copy link
Contributor

XinShuYang commented Nov 16, 2023

Upgraded hcsshim related dependencies are still compatible with the HNS API for windows agent, but I think we should investigate the new API as the old one may not be supported in future versions, I created a new issue to track this new task. #5717

antoninbas pushed a commit that referenced this issue Nov 16, 2023
For #5611

Bumps github.com/Microsoft/hcsshim from 0.9.10 to 0.11.4.

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
@XinShuYang
Copy link
Contributor

Close this issue as the PR has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Issues or PRs related to dependency changes. kind/task Categorizes issue or PR as related to a routine task that needs to be performed
Projects
None yet
Development

No branches or pull requests

2 participants