From 26816f6a02b35aa076134ade2314f7822e6bb4ec Mon Sep 17 00:00:00 2001 From: Hongliang Liu Date: Mon, 29 Aug 2022 13:26:00 +0800 Subject: [PATCH] Avoid redundant Openflow messages when syncing an updated group to OVS Fix #4159 This PR fix the issue by appending buckets directly in `Done()` in pkg/ovs/openflow/ofctrl_group.go instead of calling `AddBuckets` method of `Group` defined in the ofnet which sends an Openflow message to install the group. Signed-off-by: Hongliang Liu --- pkg/ovs/openflow/ofctrl_group.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/ovs/openflow/ofctrl_group.go b/pkg/ovs/openflow/ofctrl_group.go index ee37a35adc5..987adaeb0f7 100644 --- a/pkg/ovs/openflow/ofctrl_group.go +++ b/pkg/ovs/openflow/ofctrl_group.go @@ -135,6 +135,6 @@ func (b *bucketBuilder) Weight(val uint16) BucketBuilder { } func (b *bucketBuilder) Done() Group { - b.group.ofctrl.AddBuckets(b.bucket) + b.group.ofctrl.Buckets = append(b.group.ofctrl.Buckets, b.bucket) return b.group }