Semenyk roman #15
Open
Semenyk roman #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const InnerHtml = () => { | ||
| const hw_6 = document.querySelector('#FOR_HOMEWORK'); | ||
| hw_6.innerHTML = ` | ||
| <body> |
Owner
There was a problem hiding this comment.
You have already had body tag inside html
Comment on lines
+13
to
+24
| <div class="col"> | ||
| <button type="button" class="btn btn-primary btn-lg w-100 first-line-btn delete">Delete All</button> | ||
| </div> | ||
| <div class="col"> | ||
| <button type="button" class="btn btn-primary btn-lg w-100">Delete Last</button> | ||
| </div> | ||
| <div class="col-6"> | ||
| <input class="form-control form-control-lg w-100" type="text" placeholder="Enter todo ..."> | ||
| </div> | ||
| <div class="col"> | ||
| <button type="button" class="btn btn-primary btn-lg w-100 buttonAdd">Add</button> | ||
| </div> |
Owner
There was a problem hiding this comment.
use col- classes on buttons, less code
| const container = document.querySelector(".container-wrap"); | ||
| const content = document.querySelector(".content"); | ||
| const all = document.querySelector(".all"); | ||
| let number = 2; |
Owner
There was a problem hiding this comment.
please change variable name. Unclear what is the number
| const parentElement = document.querySelector(".buttonAdd"); | ||
| const container = document.querySelector(".container-wrap"); | ||
| const content = document.querySelector(".content"); | ||
| const all = document.querySelector(".all"); |
Owner
There was a problem hiding this comment.
The same as below. All what? PLease rename
Comment on lines
+119
to
+124
| deleteButtons.forEach(function (button) { | ||
| button.addEventListener("click", function () { | ||
| const item=this.closest(".content"); | ||
| item.remove(); | ||
| }); | ||
| }); |
| import './style.scss'; | ||
|
|
||
| // lessonsExamples.lesson_7(); | ||
| HOMEWORK.ROMAN_SEMENYK_HW.ROMAN_SEMENYK_HW_7(); |
Owner
There was a problem hiding this comment.
Please remove! It;s only for your using
antonpatotski
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.