Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not showing any search results if the "Editable" property of a note is set to "Auto" and its length exceeds the automatic readonly size #2

Open
abstractionmage opened this issue Jun 7, 2022 · 1 comment

Comments

@abstractionmage
Copy link

abstractionmage commented Jun 7, 2022

Peek 2022-06-07 21-32

When a note's "Editable" property is set to readonly, your FindWidget does not respond to theCtr+F shortcut at all (which I don't blame you for), but if its "Editable" property is set to "Auto" and it is so long that Trilium puts it into readonly mode automatically, your FindWidget does show up upon pressing Ctrl+F but it does not show any search results, which may confuse users.

I tried to find a specific segment in a very long set of lecture notes this way and was surprised that while Trilium's global search bar has picked up the relevant keyword but your FindWidget did not show any search results in the corresponding note. I began to think I was crazy until I noticed it was just a bug.

@antoniotejada
Copy link
Owner

antoniotejada commented Jun 7, 2022

Hi Thomas,

Thanks, Trilium doesn't have a consistent check for readonly notes so the findwidget only disables itself on "statically" readonly notes, not on "dynamically" readonly notes which is the "auto" case you point out.

I'm leaving this open and I'll either implement a runtime check for dynamically readonly or implement the findwidget in readonly notes in general.

Note that @zadam has ported findwidget to Trilium in https://github.com/zadam/trilium/releases/tag/v0.52.1-beta including readonly note support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants