Skip to content

Commit 645f3fd

Browse files
authored
chore: Cleanup file with test data (#311)
1 parent 1f16f09 commit 645f3fd

File tree

3 files changed

+8
-1
lines changed

3 files changed

+8
-1
lines changed

.github/CONTRIBUTING.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,10 @@ Script accept next options:
5656
| 5 | `RAW_TEST_`<br>`RESULTS_FILE_NAME` | `terraform_tfsec_pr123` | (Temporary) File where all test data will be stored. |
5757
<!-- markdownlint-enable no-inline-html -->
5858

59+
> **Note:** To make test results repeatable and comparable, be sure that on the test machine nothing generates an unstable workload. During tests good to stop any other apps and do not interact with the test machine.
60+
>
61+
> Otherwise, for eg, when you watch Youtube videos during one test and not during other, test results can differ up to 30% for the same test.
62+
5963
### Run via BASH
6064

6165
```bash

.github/workflows/release.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ on:
1010
- '**/*.sh'
1111
- 'Dockerfile'
1212
- '.pre-commit-hooks.yaml'
13-
13+
# Ignore paths
14+
- '!tests/**'
1415
jobs:
1516
release:
1617
name: Release

tests/hooks_performance_test.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ function run_tests {
1717
RESULTS_DIR="$(pwd)/tests/results"
1818

1919
cd "$TEST_DIR" || { echo "Specified TEST_DIR does not exist" && exit 1; }
20+
# Cleanup
21+
rm "$RESULTS_DIR/$FILE_NAME_TO_SAVE_TEST_RESULTS"
2022

2123
for ((i = 1; i <= TEST_NUM; i++)); do
2224
{

0 commit comments

Comments
 (0)