Tweaks to docs for fields that can be empty

justinsb · justinsb · commit 7fd55796c392 · 2017-06-16T10:15:16.000-04:00
Follow up to kubernetes#2662
diff --git a/docs/cluster_spec.md b/docs/cluster_spec.md
@@ -135,7 +135,7 @@ Will result in the flag `--runtime-config=batch/v2alpha1=true,apps/v1alpha1=true
 
 This block contains configurations for `kubelet`.  See https://kubernetes.io/docs/admin/kubelet/
 
-NOTE: Arguments can be set to empty if the field is included in the spec, and an empty string is passed to it.
+NOTE: Where the corresponding configuration value can be empty, fields can be set to empty in the spec, and an empty string will be passed as the configuration value.
  ```yaml
  spec:
    kubelet:
diff --git a/pkg/flagbuilder/buildflags_test.go b/pkg/flagbuilder/buildflags_test.go
@@ -28,7 +28,7 @@ func stringPointer(s string) *string {
 	return &s
 }
 
-func int34Pointer(i32 int32) *int32 {
+func int32Pointer(i32 int32) *int32 {
 	return &i32
 }
 
@@ -94,7 +94,7 @@ func TestKubeletConfigSpec(t *testing.T) {
 		},
 		{
 			Config: &kops.KubeletConfigSpec{
-				LogLevel: int34Pointer(2),
+				LogLevel: int32Pointer(2),
 			},
 			Expected: "--v=2",
 		},

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ func stringPointer(s string) *string {`
`28`	`28`	`return &s`
`29`	`29`	`}`
`30`	`30`
`31`		`-func int34Pointer(i32 int32) *int32 {`
	`31`	`+func int32Pointer(i32 int32) *int32 {`
`32`	`32`	`return &i32`
`33`	`33`	`}`
`34`	`34`
`@@ -94,7 +94,7 @@ func TestKubeletConfigSpec(t *testing.T) {`
`94`	`94`	`},`
`95`	`95`	`{`
`96`	`96`	`Config: &kops.KubeletConfigSpec{`
`97`		`- LogLevel: int34Pointer(2),`
	`97`	`+ LogLevel: int32Pointer(2),`
`98`	`98`	`},`
`99`	`99`	`Expected: "--v=2",`
`100`	`100`	`},`