no need to use std::packaged_task; asio supports returning a std::future directly
#1357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
approved these changes
Apr 11, 2025
| auto task = std::make_shared<std::packaged_task<decltype( f() )()>>( std::forward<F>( f ) ); | ||
| boost::asio::post( ioc, [task]() { (*task)(); } ); | ||
| return task->get_future(); | ||
| std::future<std::invoke_result_t<std::decay_t<F>>> post_async_task( boost::asio::io_context& ioc, F&& f ) { |
Contributor
There was a problem hiding this comment.
Did you specify the return type of post_async_task for clarity (as opposed to auto)?
Contributor
Author
There was a problem hiding this comment.
I did. I don't mind changing back if desired.
Contributor
There was a problem hiding this comment.
It is a little verbose, but at least it makes the return value crystal clear. I say keep as is.
You could also use:
return boost::asio::post( ioc, std::packaged_task(std::forward<F>(f)) );
which seems a bit clearer to me but again either way is fine.
Contributor
Author
There was a problem hiding this comment.
use_future is more idiomatic. It's well documented and used in many of asio's examples. Whereas being able to pass a packaged_task is only mentioned deep in the reference docs and never used in examples.
heifner
approved these changes
Apr 11, 2025
greg7mdp
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.