Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add oauth2 DSL #21

Merged
merged 1 commit into from
Feb 23, 2015
Merged

add oauth2 DSL #21

merged 1 commit into from
Feb 23, 2015
+100 −0

Conversation

masarakki
Copy link
Contributor

No description provided.

@masarakki masarakki changed the title add top-level oauth2 dsl add oauth2 DSL Feb 14, 2015
masarakki
masarakki reviewed Feb 14, 2015
View reviewed changes
lib/wine_bouncer/extension.rb
else
@last_description ||= {}
end
# case WineBouncer.configuration.auth_strategy
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't write spec with this branching because configuration is required before calling oauth2 method.

@antek-drzewiecki
Copy link
Owner

Nice! I am merging this and adding grape 10 to the build matrix.

@antek-drzewiecki antek-drzewiecki merged commit 7a51649 into antek-drzewiecki:master Feb 23, 2015
@antek-drzewiecki
Copy link
Owner

Thanks!

@masarakki masarakki deleted the easy-dsl branch February 23, 2015 22:41
@antek-drzewiecki
Copy link
Owner

@masarakki i am thinking to change the DSL from oauth2(*scopes) to authorize!(*scopes).
The naming suggest less of the implementation that is beneath the authentication of your DSL but more of the functionality. What do you think of it?

@masarakki
Copy link
Contributor Author

I cared that authorize may conflict with other libraries (ex grape himself),
so I named oauth2. (I think no one uses multiple oauth2 authenticate libraries at once.)

and authorize!(*scopes) is few information to understand how to authorize,
because there are a lot of authorization methods like Basic, Digest. OAuth, OAuth2, ...

@antek-drzewiecki
Copy link
Owner

You are right. It might result in conflicts. oauth2 will do.

@masarakki masarakki mentioned this pull request Apr 10, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@masarakki @antek-drzewiecki @onomated @calfzhou