Skip to content

feat(table): support drag sorting editable rows - #9732

Merged
chenshuai2144 merged 1 commit into
masterfrom
codex/drag-sort-editable
Oct 3, 2026
Merged

chenshuai2144 merged 1 commit into
masterfrom
codex/drag-sort-editable

Conversation

@chenshuai2144

Copy link
Copy Markdown
Contributor

Summary

  • expose the existing DragSortTable API on EditableProTable
  • keep editable cells and drag handles active in the same table
  • synchronize controlled values and name-mode form data after reordering, including active edits
  • preserve custom tableViewRender content when drag sorting is enabled

Verification

  • 92 drag-sort and editable-table tests
  • pnpm run tsc
  • pnpm run build
  • pnpm run check:declarations
  • pnpm run check:published-types
  • pnpm run check:safety
  • targeted ESLint

Closes #9046

Copilot AI balanced review requested due to automatic review settings October 3, 2026 14:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Oct 3, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 90ff4e72-e9fa-4b1d-bfe6-92e5a7cc0067
📥 Commits

Reviewing files that changed from the base of the PR and between 450b1ad and 840e3ba.

📒 Files selected for processing (4)
  • src/table/components/DragSortTable/index.tsx
  • src/table/components/EditableTable/index.tsx
  • tests/table/editableDragSort.test.tsx
  • tests/table/editableDragSortCallback.test.tsx
 _____________________________________________________________________
< Not saying it's bad... but the compiler just asked for a union rep. >
 ---------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chenshuai2144
chenshuai2144 merged commit c4d719f into master Oct 3, 2026
9 of 10 checks passed
@chenshuai2144
chenshuai2144 deleted the codex/drag-sort-editable branch October 3, 2026 14:50
@codecov

codecov Bot commented Oct 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.60%. Comparing base (450b1ad) to head (840e3ba).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9732      +/-   ##
==========================================
+ Coverage   88.58%   88.60%   +0.01%     
==========================================
  Files         421      421              
  Lines       12785    12800      +15     
  Branches     4759     4766       +7     
==========================================
+ Hits        11326    11341      +15     
  Misses       1304     1304              
  Partials      155      155              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

👑 [需求] 同时使用DragSortTable和EditableProTable

2 participants