feat: form item dep #25408
Merged
feat: form item dep #25408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afc163
reviewed
Jul 3, 2020
|
|
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6e73f01:
|
07akioni
force-pushed
the
fix-form-item-dep
branch
from
30184ff
to
457a8b5
Compare
Codecov Report
@@ Coverage Diff @@
## feature #25408 +/- ##
========================================
Coverage 99.50% 99.50%
========================================
Files 368 368
Lines 7300 7303 +3
Branches 2048 2001 -47
========================================
+ Hits 7264 7267 +3
Misses 36 36
Continue to review full report at Codecov.
|
zombieJ
reviewed
Jul 3, 2020
components/form/FormItem.tsx
Outdated
| @@ -299,14 +299,21 @@ function FormItem(props: FormItemProps): React.ReactElement { | |||
| }; | |||
|
|
|||
| let childNode: React.ReactNode = null; | |||
| if (shouldUpdate && dependencies) { | |||
|
文档还要补一下什么时候支持的 |
zombieJ
approved these changes
Jul 3, 2020
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
resolve #21645
💡 Background and solution
📝 Changelog
dependenciesto control updating logic with render props children.dependencies控制更新逻辑。☑️ Self Check before Merge
View rendered components/form/demo/dep-debug.md