Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table dropdown prefix cls #22133

Merged
merged 3 commits into from
Mar 11, 2020
Merged

fix: Table dropdown prefix cls #22133

merged 3 commits into from
Mar 11, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 11, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #22091

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix ConfigProvider not work on Table filter dropdown.
🇨🇳 Chinese 修复 ConfigProvider 没有作用在 Table 过滤弹框上的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 11, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7838187:

Sandbox Source
antd reproduction template Configuration
antd-table-dropdown-bug Issue #22091

@zombieJ zombieJ merged commit f44f6f3 into master Mar 11, 2020
@zombieJ zombieJ deleted the table-dropdown-prefixCls branch March 11, 2020 15:58
@pr-triage pr-triage bot added the PR: merged label Mar 11, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0753319:

Sandbox Source
antd reproduction template Configuration
antd-table-dropdown-bug Issue #22091

@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #22133 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22133   +/-   ##
=======================================
  Coverage   97.96%   97.96%           
=======================================
  Files         306      306           
  Lines        7042     7042           
  Branches     1939     1893   -46     
=======================================
  Hits         6899     6899           
  Misses        143      143
Impacted Files Coverage Δ
components/table/hooks/useFilter/index.tsx 100% <ø> (ø) ⬆️
components/table/Table.tsx 96.74% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ec2b77...0753319. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

table dropdown not respecting prefixCls from ConfigProvider
2 participants