Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strongly suggest to add a prop in Modal, like onRequestClose #773

Closed
1 task
bimbox-open opened this issue Mar 18, 2020 · 2 comments
Closed
1 task

strongly suggest to add a prop in Modal, like onRequestClose #773

bimbox-open opened this issue Mar 18, 2020 · 2 comments

Comments

@bimbox-open
Copy link

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

in many many case, I can only deal with android device back button in Modal.alert(title, message,actions,onBackHanlder), or Modal.prompt(...).
But in <Modal {...props}/>, I have no idea about dealing with android device back button.
In my project, there are a lot of <Modal ... /> component, but after Pressing the device back button, how to close the modal?
I don't understand why to delete onRequestClose prop in RN.
hope your reply.

What does the proposed API look like?

@BANG88
Copy link
Member

BANG88 commented Mar 20, 2020

@bimbox-open I remember that we don't have a props named onRequestClose.

@BANG88
Copy link
Member

BANG88 commented Apr 3, 2020

@1uokun 可以顺便看看这个吗?

@BANG88 BANG88 closed this as completed in a8e3fdd Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants