Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differences between vendored Docker SDK for Python code and Docker SDK for Python #435

Open
felixfontein opened this issue Jul 31, 2022 · 12 comments
Labels

Comments

@felixfontein
Copy link
Collaborator

SUMMARY

This issue is for tracking differences that need to be checked (whether our vendored code needs to be updated accordingly) that appear in the Docker SDK for Python in https://github.com/docker/docker-py/commits/main

ISSUE TYPE
  • Tracking
COMPONENT NAME

plugins/module_utils/_api/

@felixfontein
Copy link
Collaborator Author

@felixfontein
Copy link
Collaborator Author

@felixfontein
Copy link
Collaborator Author

@felixfontein
Copy link
Collaborator Author

Docker SDK for Python 6.0.0 has been released. All changes in it have been incorporated (i.e. in the last 10 days there have been no new commits which affect code that's vendored here).

@felixfontein
Copy link
Collaborator Author

@felixfontein
Copy link
Collaborator Author

felixfontein commented Dec 1, 2022

Not yet there: docker/docker-py@82cf559...main

@felixfontein
Copy link
Collaborator Author

#581 and #582 update this to docker/docker-py@aca129d...main

@felixfontein
Copy link
Collaborator Author

felixfontein commented May 10, 2023

#619 updates this to docker/docker-py@bc4c0d7...main.

@felixfontein
Copy link
Collaborator Author

#694 updates this to docker/docker-py@c38656d...main.

@felixfontein
Copy link
Collaborator Author

There currently isn't really something to update. The only potentially interesting change is docker/docker-py#3185, but the only relevant part is that it removes features that we still need (ssl_version and tls_hostname). I don't see why tls_hostname is removed, since the only part of it that needs something removed from Python 3.12 is the tests, but not the feature itself. Deprecating ssl_version is fine though.

So the next changes to look for are at docker/docker-py@b6464db...main.

@felixfontein
Copy link
Collaborator Author

There currently isn't really something to update, since the only real change was already integrated in this collection before it got merged to Docker SDK for Python (the requests fix). The next changes to look for are at docker/docker-py@a365202...main.

@felixfontein
Copy link
Collaborator Author

There are currently only docs and tests changes. The next changes to look for are at docker/docker-py@a8bac88...main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant