Skip to content

Commit a79a0fe

Browse files
targosanonrig
authored andcommitted
deps: patch V8 to 11.8.172.17
Refs: v8/v8@11.8.172.15...11.8.172.17 PR-URL: nodejs#50292 Refs: v8/v8@11.8.172.15...11.8.172.16 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
1 parent 7478b77 commit a79a0fe

File tree

8 files changed

+38
-97
lines changed

8 files changed

+38
-97
lines changed

deps/v8/include/v8-version.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#define V8_MAJOR_VERSION 11
1212
#define V8_MINOR_VERSION 8
1313
#define V8_BUILD_NUMBER 172
14-
#define V8_PATCH_LEVEL 15
14+
#define V8_PATCH_LEVEL 17
1515

1616
// Use 1 for candidates and 0 otherwise.
1717
// (Boolean macro values are not supported by all preprocessors.)

deps/v8/infra/mb/mb_config.pyl

+17-21
Original file line numberDiff line numberDiff line change
@@ -579,7 +579,7 @@
579579
'release_x64_gcmole': [
580580
'release_bot', 'x64', 'gcmole'],
581581
'release_x64_msvc': [
582-
'release_bot_no_goma', 'x64', 'minimal_symbols', 'msvc'],
582+
'release_bot_no_reclient', 'x64', 'minimal_symbols', 'msvc'],
583583
'release_x64_correctness_fuzzer' : [
584584
'release_bot', 'x64', 'v8_correctness_fuzzer'],
585585
'release_x64_disable_runtime_call_stats': [
@@ -589,7 +589,7 @@
589589
'release_x64_fuchsia_trybot': [
590590
'release_trybot', 'x64', 'fuchsia'],
591591
'release_x64_gcc': [
592-
'release_bot_no_goma', 'x64', 'gcc', 'lld', 'no_custom_libcxx'],
592+
'release_bot_no_reclient', 'x64', 'gcc', 'lld', 'no_custom_libcxx'],
593593
'release_x64_ios_simulator': [
594594
'release_bot', 'x64', 'ios_simulator'],
595595
'release_x64_internal': [
@@ -648,7 +648,7 @@
648648
'debug_x64_asan': [
649649
'debug_bot', 'x64', 'asan', 'lsan'],
650650
'debug_x64_asan_no_lsan_static': [
651-
'debug', 'static', 'goma', 'v8_enable_slow_dchecks', 'v8_optimized_debug',
651+
'debug', 'static', 'reclient', 'v8_enable_slow_dchecks', 'v8_optimized_debug',
652652
'x64', 'asan'],
653653
'debug_x64_conservative_stack_scanning': [
654654
'debug_bot', 'x64', 'conservative_stack_scanning'],
@@ -661,7 +661,7 @@
661661
'debug_x64_fuchsia': [
662662
'debug_bot', 'x64', 'fuchsia'],
663663
'debug_x64_gcc': [
664-
'debug_bot_no_goma', 'x64', 'gcc', 'lld', 'no_custom_libcxx'],
664+
'debug_bot_no_reclient', 'x64', 'gcc', 'lld', 'no_custom_libcxx'],
665665
'debug_x64_header_includes': [
666666
'debug_bot', 'x64', 'v8_check_header_includes'],
667667
'debug_x64_no_shared_cage': [
@@ -696,15 +696,15 @@
696696
'debug_x86_minimal_symbols': [
697697
'debug_bot', 'x86', 'minimal_symbols'],
698698
'debug_x86_msvc': [
699-
'debug_bot_no_goma', 'x86', 'minimal_symbols', 'msvc'],
699+
'debug_bot_no_reclient', 'x86', 'minimal_symbols', 'msvc'],
700700
'debug_x86_no_i18n': [
701701
'debug_bot', 'x86', 'v8_no_i18n'],
702702
'debug_x86_trybot': [
703703
'debug_trybot', 'x86'],
704704
'debug_x86_vtunejit': [
705705
'debug_bot', 'x86', 'v8_enable_vtunejit'],
706706
'full_debug_x86': [
707-
'debug', 'x86', 'goma', 'v8_enable_slow_dchecks', 'v8_full_debug'],
707+
'debug', 'x86', 'reclient', 'v8_enable_slow_dchecks', 'v8_full_debug'],
708708

709709
# Release configs for x86.
710710
'release_x86': [
@@ -725,7 +725,7 @@
725725
'release_x64_predictable': [
726726
'release_bot', 'x64', 'v8_enable_verify_predictable'],
727727
'release_x86_shared_verify_heap': [
728-
'release', 'x86', 'goma', 'shared', 'v8_verify_heap'],
728+
'release', 'x86', 'reclient', 'shared', 'v8_verify_heap'],
729729
'release_x86_trybot': [
730730
'release_trybot', 'x86'],
731731
'release_x86_verify_csa': [
@@ -813,19 +813,19 @@
813813

814814
'debug_bot_no_slow_dchecks': {
815815
'mixins': [
816-
'debug', 'shared', 'goma', 'v8_disable_slow_dchecks',
816+
'debug', 'shared', 'reclient', 'v8_disable_slow_dchecks',
817817
'v8_optimized_debug', 'v8_enable_google_benchmark'],
818818
},
819819

820820
'debug_bot': {
821821
'mixins': [
822-
'debug', 'shared', 'goma', 'v8_enable_slow_dchecks',
822+
'debug', 'shared', 'reclient', 'v8_enable_slow_dchecks',
823823
'v8_optimized_debug', 'v8_enable_google_benchmark'],
824824
},
825825

826-
'debug_bot_no_goma': {
826+
'debug_bot_no_reclient': {
827827
'mixins': [
828-
'debug', 'shared', 'no_goma', 'v8_enable_slow_dchecks',
828+
'debug', 'shared', 'no_reclient', 'v8_enable_slow_dchecks',
829829
'v8_optimized_debug'],
830830
},
831831

@@ -867,10 +867,6 @@
867867
'gn_args': 'v8_gcmole=true',
868868
},
869869

870-
'goma': {
871-
'gn_args': 'use_goma=true',
872-
},
873-
874870
'hard_float': {
875871
'gn_args': 'arm_float_abi="hard"',
876872
},
@@ -910,8 +906,8 @@
910906
'gn_args': 'use_custom_libcxx=false',
911907
},
912908

913-
'no_goma': {
914-
'gn_args': 'use_goma=false',
909+
'no_reclient': {
910+
'gn_args': 'use_remoteexec=false',
915911
},
916912

917913
'no_sandbox': {
@@ -935,15 +931,15 @@
935931
},
936932

937933
'release_bot': {
938-
'mixins': ['release', 'static', 'goma', 'v8_enable_google_benchmark'],
934+
'mixins': ['release', 'static', 'reclient', 'v8_enable_google_benchmark'],
939935
},
940936

941-
'release_bot_no_goma': {
942-
'mixins': ['release', 'static', 'no_goma'],
937+
'release_bot_no_reclient': {
938+
'mixins': ['release', 'static', 'no_reclient'],
943939
},
944940

945941
'release_bot_reclient': {
946-
'mixins': ['release', 'static', 'no_goma', 'reclient'],
942+
'mixins': ['release', 'static', 'reclient'],
947943
},
948944

949945
'release_trybot': {

deps/v8/src/objects/js-function.cc

+6-6
Original file line numberDiff line numberDiff line change
@@ -1083,13 +1083,13 @@ MaybeHandle<Map> JSFunction::GetDerivedMap(Isolate* isolate,
10831083
isolate);
10841084
prototype = handle(realm_constructor->prototype(), isolate);
10851085
}
1086-
CHECK(IsJSReceiver(*prototype));
1087-
DCHECK_EQ(constructor_initial_map->constructor_or_back_pointer(),
1088-
*constructor);
10891086

1090-
Handle<Map> map = Map::TransitionToDerivedMap(
1091-
isolate, constructor_initial_map, Handle<HeapObject>::cast(prototype));
1092-
DCHECK_EQ(map->constructor_or_back_pointer(), *constructor);
1087+
Handle<Map> map = Map::CopyInitialMap(isolate, constructor_initial_map);
1088+
map->set_new_target_is_base(false);
1089+
CHECK(IsJSReceiver(*prototype));
1090+
if (map->prototype() != *prototype)
1091+
Map::SetPrototype(isolate, map, Handle<HeapObject>::cast(prototype));
1092+
map->SetConstructor(*constructor);
10931093
return map;
10941094
}
10951095

deps/v8/src/objects/map.cc

+3-21
Original file line numberDiff line numberDiff line change
@@ -2344,31 +2344,13 @@ void Map::StartInobjectSlackTracking() {
23442344

23452345
Handle<Map> Map::TransitionToPrototype(Isolate* isolate, Handle<Map> map,
23462346
Handle<HeapObject> prototype) {
2347-
Handle<Map> new_map = TransitionsAccessor::GetPrototypeTransition(
2348-
isolate, map, prototype, map->new_target_is_base());
2347+
Handle<Map> new_map =
2348+
TransitionsAccessor::GetPrototypeTransition(isolate, map, prototype);
23492349
if (new_map.is_null()) {
23502350
new_map = Copy(isolate, map, "TransitionToPrototype");
23512351
TransitionsAccessor::PutPrototypeTransition(isolate, map, prototype,
23522352
new_map);
2353-
if (*prototype != map->prototype()) {
2354-
Map::SetPrototype(isolate, new_map, prototype);
2355-
}
2356-
}
2357-
return new_map;
2358-
}
2359-
2360-
Handle<Map> Map::TransitionToDerivedMap(Isolate* isolate, Handle<Map> map,
2361-
Handle<HeapObject> prototype) {
2362-
Handle<Map> new_map = TransitionsAccessor::GetPrototypeTransition(
2363-
isolate, map, prototype, /* new_target_is_base */ false);
2364-
if (new_map.is_null()) {
2365-
new_map = CopyInitialMap(isolate, map);
2366-
TransitionsAccessor::PutPrototypeTransition(isolate, map, prototype,
2367-
new_map);
2368-
if (*prototype != map->prototype()) {
2369-
Map::SetPrototype(isolate, new_map, prototype);
2370-
}
2371-
new_map->set_new_target_is_base(false);
2353+
Map::SetPrototype(isolate, new_map, prototype);
23722354
}
23732355
return new_map;
23742356
}

deps/v8/src/objects/map.h

-3
Original file line numberDiff line numberDiff line change
@@ -863,9 +863,6 @@ class Map : public TorqueGeneratedMap<Map, HeapObject> {
863863
V8_EXPORT_PRIVATE static Handle<Map> TransitionToPrototype(
864864
Isolate* isolate, Handle<Map> map, Handle<HeapObject> prototype);
865865

866-
V8_EXPORT_PRIVATE static Handle<Map> TransitionToDerivedMap(
867-
Isolate* isolate, Handle<Map> map, Handle<HeapObject> prototype);
868-
869866
static Handle<Map> TransitionToImmutableProto(Isolate* isolate,
870867
Handle<Map> map);
871868

deps/v8/src/objects/transitions.cc

+2-4
Original file line numberDiff line numberDiff line change
@@ -443,8 +443,7 @@ void TransitionsAccessor::PutPrototypeTransition(Isolate* isolate,
443443

444444
// static
445445
Handle<Map> TransitionsAccessor::GetPrototypeTransition(
446-
Isolate* isolate, Handle<Map> map, Handle<Object> prototype_handle,
447-
bool new_target_is_base) {
446+
Isolate* isolate, Handle<Map> map, Handle<Object> prototype_handle) {
448447
DisallowGarbageCollection no_gc;
449448
Object prototype = *prototype_handle;
450449
Tagged<WeakFixedArray> cache = GetPrototypeTransitions(isolate, map);
@@ -456,8 +455,7 @@ Handle<Map> TransitionsAccessor::GetPrototypeTransition(
456455
Tagged<HeapObject> heap_object;
457456
if (target.GetHeapObjectIfWeak(&heap_object)) {
458457
Tagged<Map> target_map = Map::cast(heap_object);
459-
if (target_map->prototype() == prototype &&
460-
target_map->new_target_is_base() == new_target_is_base) {
458+
if (target_map->prototype() == prototype) {
461459
return handle(target_map, isolate);
462460
}
463461
}

deps/v8/src/objects/transitions.h

+9-10
Original file line numberDiff line numberDiff line change
@@ -124,20 +124,19 @@ class V8_EXPORT_PRIVATE TransitionsAccessor {
124124
}
125125

126126
// ===== PROTOTYPE TRANSITIONS =====
127-
// When you set the prototype of an object using the __proto__ accessor, or if
128-
// an unrelated new.target is passed to a constructor you need a new map for
129-
// the object (the prototype is stored in the map). In order not to multiply
130-
// maps unnecessarily we store these as transitions in the original map. That
131-
// way we can transition to the same map if the same prototype is set, rather
132-
// than creating a new map every time. The transitions are in the form of a
133-
// map where the keys are prototype objects and the values are the maps they
134-
// transition to. PutPrototypeTransition can trigger GC.
127+
// When you set the prototype of an object using the __proto__ accessor you
128+
// need a new map for the object (the prototype is stored in the map). In
129+
// order not to multiply maps unnecessarily we store these as transitions in
130+
// the original map. That way we can transition to the same map if the same
131+
// prototype is set, rather than creating a new map every time. The
132+
// transitions are in the form of a map where the keys are prototype objects
133+
// and the values are the maps they transition to.
134+
// PutPrototypeTransition can trigger GC.
135135
static void PutPrototypeTransition(Isolate* isolate, Handle<Map>,
136136
Handle<Object> prototype,
137137
Handle<Map> target_map);
138138
static Handle<Map> GetPrototypeTransition(Isolate* isolate, Handle<Map> map,
139-
Handle<Object> prototype,
140-
bool new_target_is_base);
139+
Handle<Object> prototype);
141140

142141
// During the first-time Map::Update and Map::TryUpdate, the migration target
143142
// map could be cached in the raw_transitions slot of the old map that is

deps/v8/test/mjsunit/regress/regress-reflect-construct.js

-31
This file was deleted.

0 commit comments

Comments
 (0)