lib: use ArrayBuffer.prototype.transfer

Author: anonrig

lib/internal/webstreams/readablestream.js

@@ -105,7 +105,6 @@ const {
   isBrandCheck,
   resetQueue,
   setPromiseHandled,
-  transferArrayBuffer,
   nonOpCancel,
   nonOpPull,
   nonOpStart,
@@ -1954,7 +1953,7 @@ function readableByteStreamControllerConvertPullIntoDescriptor(desc) {
   if (bytesFilled > byteLength)
     throw new ERR_INVALID_STATE.RangeError('The buffer size is invalid');
   assert(!(bytesFilled % elementSize));
-  const transferredBuffer = transferArrayBuffer(buffer);
+  const transferredBuffer = buffer.transfer();
 
   if (ctor === Buffer) {
     return Buffer.from(transferredBuffer, byteOffset, bytesFilled / elementSize);
@@ -2623,7 +2622,7 @@ function readableByteStreamControllerPullInto(
 
   let transferredBuffer;
   try {
-    transferredBuffer = transferArrayBuffer(buffer);
+    transferredBuffer = buffer.transfer();
   } catch (error) {
     readIntoRequest[kError](error);
     return;
@@ -2715,7 +2714,7 @@ function readableByteStreamControllerRespond(controller, bytesWritten) {
       throw new ERR_INVALID_ARG_VALUE.RangeError('bytesWritten', bytesWritten);
   }
 
-  desc.buffer = transferArrayBuffer(desc.buffer);
+  desc.buffer = desc.buffer.transfer();
 
   readableByteStreamControllerRespondInternal(controller, bytesWritten);
 }
@@ -2765,7 +2764,7 @@ function readableByteStreamControllerEnqueue(controller, chunk) {
   if (closeRequested || stream[kState].state !== 'readable')
     return;
 
-  const transferredBuffer = transferArrayBuffer(buffer);
+  const transferredBuffer = buffer.transfer();
 
   if (pendingPullIntos.length) {
     const firstPendingPullInto = pendingPullIntos[0];
@@ -2778,9 +2777,7 @@ function readableByteStreamControllerEnqueue(controller, chunk) {
 
     readableByteStreamControllerInvalidateBYOBRequest(controller);
 
-    firstPendingPullInto.buffer = transferArrayBuffer(
-      firstPendingPullInto.buffer,
-    );
+    firstPendingPullInto.buffer = firstPendingPullInto.buffer.transfer();
 
     if (firstPendingPullInto.type === 'none') {
       readableByteStreamControllerEnqueueDetachedPullIntoToQueue(
@@ -3075,7 +3072,7 @@ function readableByteStreamControllerRespondWithNewView(controller, view) {
   if (bufferByteLength !== viewBufferByteLength)
     throw new ERR_INVALID_ARG_VALUE.RangeError('view', view);
 
-  desc.buffer = transferArrayBuffer(viewBuffer);
+  desc.buffer = viewBuffer.transfer();
 
   readableByteStreamControllerRespondInternal(controller, viewByteLength);
 }

lib/internal/webstreams/util.js

@@ -21,14 +21,12 @@ const {
 const {
   codes: {
     ERR_INVALID_ARG_VALUE,
-    ERR_OPERATION_FAILED,
     ERR_INVALID_STATE,
   },
 } = require('internal/errors');
 
 const {
   copyArrayBuffer,
-  detachArrayBuffer,
 } = internalBinding('buffer');
 
 const {
@@ -122,15 +120,6 @@ function isBrandCheck(brand) {
   };
 }
 
-function transferArrayBuffer(buffer) {
-  const res = detachArrayBuffer(buffer);
-  if (res === undefined) {
-    throw new ERR_OPERATION_FAILED.TypeError(
-      'The ArrayBuffer could not be transferred');
-  }
-  return res;
-}
-
 function dequeueValue(controller) {
   assert(controller[kState].queue !== undefined);
   assert(controller[kState].queueTotalSize !== undefined);
@@ -279,7 +268,6 @@ module.exports = {
   peekQueueValue,
   resetQueue,
   setPromiseHandled,
-  transferArrayBuffer,
   nonOpCancel,
   nonOpFlush,
   nonOpPull,