Update release workflow with permissions and Node.js version #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genaris
approved these changes
Oct 4, 2025
TimoGlastra
approved these changes
Oct 4, 2025
|
|
||
| # Ensure npm >= 11.5.1 for trusted publishing support | ||
| - name: Update npm | ||
| run: npm install -g npm@11.5.1 |
Contributor
There was a problem hiding this comment.
Shouldn't we install it as @^11.5.1 so we get (security) updates
Contributor
Author
There was a problem hiding this comment.
@TimoGlastra , thank you for your comment. I am ok with it if the maintainers agree.
I pinned the version for reproducibility and to avoid sudden breakages but i am ok if you want to catch future security updates.
I will make the change and let others comment.
Added permissions for contents and id-token in release jobs, updated Node.js version to 22, and removed .npmrc creation step. Signed-off-by: Jessica G <jwagantall@linuxfoundation.org>
Signed-off-by: Jessica G <jwagantall@linuxfoundation.org>
Signed-off-by: Jessica G <jwagantall@linuxfoundation.org>
jwagantall
force-pushed
the
npm-migration
branch
from
db906de to
e82d777
Compare
Contributor
|
We need to get a new release of the wrapper published. Is this PR ready to go? There was a question left hanging that is holding back the merging of this PR. Once this is done, we need to get the new 0.2.3 release tagged and published as soon as possible. |
Contributor
|
Collected comments and it is fine to merge this without the change. May be added later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added permissions for contents and id-token in release jobs, updated Node.js version to 22, and removed .npmrc creation step.
Fix: #12