feat(mcp): add elicitation request handling#8243
Open
mattzcarey wants to merge 5 commits intoanomalyco:devfrom
Open
feat(mcp): add elicitation request handling#8243mattzcarey wants to merge 5 commits intoanomalyco:devfrom
mattzcarey wants to merge 5 commits intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Collaborator
|
We should prolly update this too: opencode/packages/opencode/src/cli/cmd/mcp.ts Line 651 in 80e1173 Since this is a more recent addition to protocol |
8bebbcf to
4c21af6
Compare
Author
|
done. @rekram1-node |
Collaborator
|
/review |
packages/opencode/src/cli/cmd/tui/routes/session/elicitation-schema.ts
Outdated
Show resolved
Hide resolved
Contributor
|
lgtm |
544c02d to
061b108
Compare
95daa62 to
38a5def
Compare
Add support for MCP elicitation requests across the codebase: - Add elicitation store to sync context with requested/completed/rejected event handlers - Add ElicitationPrompt component to session UI with priority after permissions and questions - Register elicitation identifier prefix "eli" - Implement elicitation request handler in MCP client with form capabilities - Add /mcp/elicitation routes for list, reply, and reject operations - Update protocol version to 2025-11-25 for elicitation support - Generate SDK types
38a5def to
afbdbda
Compare
- Use onMount for initializing default values in ElicitationPrompt - Add validation error state and display in UI - Use zod safeParse for schema validation instead of type assertion - Return 404 for unknown elicitation IDs in reply/reject endpoints
- Use early return pattern in toggleMultiSelect - Refactor schemaToFields to use Object.entries().map()
Author
|
@rekram1-node ready for you to play with |
9 tasks
Collaborator
|
Will do just have a backlog to go through unfortunately, but this is on my list |
00637c0 to
71e0ba2
Compare
f1ae801 to
08fa7f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for MCP elicitation requests across the codebase:
What does this PR do?
adds elicitation for human in the loop.
How did you verify your code works?
it works locally for me
Closes #8251