fix(fxcron): Fix resolution collision by using full import path in type IDs (#366)

Author: damnedest

fxcron/info.go

@@ -1,7 +1,6 @@
 package fxcron
 
 import (
-	"reflect"
 	"time"
 
 	"github.com/go-co-op/gocron/v2"
@@ -94,5 +93,5 @@ func (i *FxCronModuleInfo) jobNextRun(job gocron.Job) string {
 }
 
 func (i *FxCronModuleInfo) jobType(job CronJob) string {
-	return reflect.ValueOf(job).Type().String()
+	return GetType(job)
 }

fxcron/module_test.go

@@ -360,7 +360,7 @@ func TestModuleInfo(t *testing.T) {
 						"expression": `*/1 * * * * *`,
 						"last_run":   time.Time{}.Format(time.RFC3339),
 						"next_run":   startAt.Format(time.RFC3339),
-						"type":       "*job.DummyCron",
+						"type":       "github.com/ankorstore/yokai/fxcron/testdata/cron/job.DummyCron",
 					},
 				},
 				"unscheduled": map[string]interface{}{},

fxcron/reflect.go

@@ -4,12 +4,39 @@ import (
 	"reflect"
 )
 
-// GetType returns the type of a target.
+// fullTypeID builds a stable identifier for a type in the form "<pkgpath>.<TypeName>".
+func fullTypeID(t reflect.Type) string {
+	if t == nil {
+		return ""
+	}
+
+	// Unwrap pointers to get the underlying named type (if any).
+	for t.Kind() == reflect.Pointer {
+		t = t.Elem()
+	}
+
+	// For named types, PkgPath() + Name() gives a unique and stable identity.
+	if t.Name() != "" && t.PkgPath() != "" {
+		return t.PkgPath() + "." + t.Name()
+	}
+
+	// Fallback for non-named kinds (slices, maps, func, etc.).
+	return t.String()
+}
+
+// GetType returns a stable identifier for the given target’s type.
 func GetType(target any) string {
-	return reflect.TypeOf(target).String()
+	return fullTypeID(reflect.TypeOf(target))
 }
 
-// GetReturnType returns the return type of a target.
+// GetReturnType returns a stable identifier for the return type of constructor-like target.
+// If a target is a function, we examine its first return value (index 0), unwrap pointers, and
+// build an identifier for that named type. For non-function or empty-return cases, we return "".
 func GetReturnType(target any) string {
-	return reflect.TypeOf(target).Out(0).String()
+	t := reflect.TypeOf(target)
+	if t == nil || t.Kind() != reflect.Func || t.NumOut() == 0 {
+		return ""
+	}
+
+	return fullTypeID(t.Out(0))
 }

fxcron/reflect_test.go

@@ -17,7 +17,7 @@ func TestGetType(t *testing.T) {
 	}{
 		{123, "int"},
 		{"test", "string"},
-		{tracker.NewCronExecutionTracker(), "*tracker.CronExecutionTracker"},
+		{tracker.NewCronExecutionTracker(), "github.com/ankorstore/yokai/fxcron/testdata/cron/tracker.CronExecutionTracker"},
 	}
 
 	for _, tt := range tests {