From 1dac2259af19ce3bb61903bc94168c5b9d9b89b4 Mon Sep 17 00:00:00 2001 From: ana-balica Date: Sun, 6 Mar 2016 16:05:32 +0000 Subject: [PATCH] Remove notes about SECRET_KEY travis-ci from docs --- docs/develop/contributing.rst | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/docs/develop/contributing.rst b/docs/develop/contributing.rst index fb6447a6..6822419a 100644 --- a/docs/develop/contributing.rst +++ b/docs/develop/contributing.rst @@ -60,7 +60,7 @@ show you step by step how to make a contribution to Systers Portal. #. Choose a task to work on. It can be a beginners task or a sophisticated feature you want to implement for Portal. For beginners we have tasks with `easy TODO tag on GitHub issues `_. -#. Create a new feature branch from ``develop`` branch. The feature branch +#. Create a new feature branch from ``develop`` branch. The feature branch should have a short and relevant name. :: $ git checkout -b @@ -84,7 +84,7 @@ show you step by step how to make a contribution to Systers Portal. same level or improve the test coverage. #. If you have made any changes to the HTML or have manipulates the DOM - using JavaScript, please check the validity of the file. Open the page + using JavaScript, please check the validity of the file. Open the page in the browser, copy the page source code and paste it `here `_. If there are errors, please correct them and revalidate. @@ -179,12 +179,5 @@ to Systers Portal repo, Travis builds our project and runs the tests. It also notifies us about any errors or failures, that way preventing us from breaking the project. -If you will make a pull request, you will see that Travis build will fail -always. This doesn't mean that your change broke Portal. It happens because of -a security issue, Travis being unable to decrypt the ``SECRET_KEY`` from an -unknown source. Unknown source being you, since you are not a member of the -repo. Hence it is the responsibility of the repo admins to fetch your branch -and push it to GitHub themselves to check Travis build output. - Along with Travis CI, we use code test coverage metric using coveralls service. Please note that high coverage is not a guarantee for good tests.