Skip to content

Added onclick configuration option, event handler/dispatcher and rele… #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RogerWebb
Copy link

I added a simple "onclick" event dispatcher. README.md has an example (#4 under Key Features), demonstrating it's use. Please let me know if you have any questions or concerns with the PR. I think there are more people like myself that may find it useful and I may have another idea or two to contribute if you're interested in merging.

Cheers!

Roger

// Handle User-Defined onclick event, if defined
if(widget.config.hasOwnProperty('onclick')) {
widget.config.onclick(hotspot)
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RogerWebb It's a nice feature to have. But what's the plan for spot_html element when onclick is defined in the widget config. I think it should also get handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants