Update uploads and downloads to be recursive by default

Author: rubenvanassche

src/Scp.php

@@ -53,6 +53,8 @@ protected function getExtraOptions(): string
     {
         $extraOptions = [];
 
+        $extraOptions[] = '-r';
+
         if ($this->pathToPrivateKey) {
             $extraOptions[] = "-i {$this->pathToPrivateKey}";
         }
@@ -66,10 +68,6 @@ protected function getExtraOptions(): string
             $extraOptions[] = '-o UserKnownHostsFile=/dev/null';
         }
 
-        if ($this->recursive) {
-            $extraOptions[] = '-r';
-        }
-
         return implode(' ', $extraOptions);
     }
 }

tests/ScpTest.php

@@ -36,22 +36,6 @@ public function it_can_upload_a_file()
         $this->assertMatchesSnapshot($command);
     }
 
-    /** @test */
-    public function it_can_download_files_recursively()
-    {
-        $command = $this->scp->recursive()->getDownloadCommand('spatie.be/current', 'downloads');
-
-        $this->assertMatchesSnapshot($command);
-    }
-
-    /** @test */
-    public function it_can_upload_files_recursively()
-    {
-        $command = $this->scp->recursive()->getUploadCommand('uploads', 'spatie.be/current');
-
-        $this->assertMatchesSnapshot($command);
-    }
-
     /** @test */
     public function it_can_use_a_specific_private_key()
     {

tests/__snapshots__/ScpTest__it_can_disable_strict_host_checking__1.txt

@@ -1 +1 @@
-scp -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null user@example.com:spatie.be/current/.env .env
+scp -r -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null user@example.com:spatie.be/current/.env .env

tests/__snapshots__/ScpTest__it_can_download_a_file__1.txt

@@ -1 +1 @@
-scp  user@example.com:spatie.be/current/.env .env
+scp -r user@example.com:spatie.be/current/.env .env

tests/__snapshots__/ScpTest__it_can_download_files_recursively__1.txt

@@ -1 +1 @@
-scp  user@example.com:spatie.be/current/.env .env
+scp -r user@example.com:spatie.be/current/.env .env

tests/__snapshots__/ScpTest__it_can_enable_strict_host_checking__1.txt

@@ -1 +1 @@
-scp -P 123 user@example.com:spatie.be/current/.env .env
+scp -r -P 123 user@example.com:spatie.be/current/.env .env

tests/__snapshots__/ScpTest__it_can_set_the_port_via_the_constructor__1.txt

@@ -1 +1 @@
-scp -P 123 user@example.com:spatie.be/current/.env .env
+scp -r -P 123 user@example.com:spatie.be/current/.env .env

tests/__snapshots__/ScpTest__it_can_set_the_port_via_the_dedicated_function__1.txt

@@ -1 +1 @@
-scp  .env user@example.com:spatie.be/current/.env
+scp -r .env user@example.com:spatie.be/current/.env