Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flyout z-index and content going behind close trigger #237

Merged
merged 1 commit into from
May 29, 2024

Conversation

coopbri
Copy link
Contributor

@coopbri coopbri commented May 29, 2024

Description

Task link: N/A
  • Flyout positioner didn't have z-index applied, so would go behind most content -- resolved by setting z-index to the menu token
  • Flyout close trigger was overlaid on content -- resolved by adding padding to content container

Test Steps

  • Verify Flyout visually works well based on fixes above

Copy link

changeset-bot bot commented May 29, 2024

🦋 Changeset detected

Latest commit: 9f6af7f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@animareflection/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coopbri coopbri merged commit 9c34dc1 into master May 29, 2024
1 of 2 checks passed
@coopbri coopbri deleted the fix/flyout branch May 29, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant