Skip to content

Commit e17aebb

Browse files
committed
updated changelog, codestyle fixes
1 parent f840022 commit e17aebb

File tree

3 files changed

+18
-12
lines changed

3 files changed

+18
-12
lines changed

CHANGELOG.md

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,12 @@ Features:
1111
* [WebDriver] Shadow DOM Support for `Webdriver`. See #2741 by @gkushang
1212
* [Release management] Introduce the versioning automatically, it follows the semantics versioning. See #2883 by @PeterNgTr
1313
* Adding opts into `Scenario.skip` that it would be useful for building reports. See #2867 by @AlexKo4
14+
* Added support for attaching screenshots to [cucumberJsonReporter](https://github.com/ktryniszewski-mdsol/codeceptjs-cucumber-json-reporter) See #2888 by @fijijavis
15+
* Supported config file for `codeceptjs shell` command. See #2895 by @PeterNgTr:
16+
17+
```
18+
npx codeceptjs shell -c foo.conf.js
19+
```
1420

1521
Bug fixes:
1622
* [GraphQL] Use a helper-specific instance of Axios to avoid contaminating global defaults. See #2868 by @vanvoljg
@@ -20,11 +26,11 @@ Bug fixes:
2026

2127
## 3.0.6
2228

23-
* [Playwright] Added `electron` as a browser to config. See #2834 by @cbayer97
29+
* [Playwright] Added `electron` as a browser to config. See #2834 by @cbayer97
2430
* [Playwright] Implemented `launchPersistentContext` to be able to launch persistent remote browsers. See #2817 by @brunoqueiros. Fixes #2376.
2531
* Fixed printing logs and stack traces for `run-workers`. See #2857 by @haveac1gar. Fixes #2621, #2852
26-
* Emit custom messages from worker to the main thread. See #2824 by @jccguimaraes
27-
* Improved workers processes output. See #2804 by @drfiresign
32+
* Emit custom messages from worker to the main thread. See #2824 by @jccguimaraes
33+
* Improved workers processes output. See #2804 by @drfiresign
2834
* BDD. Added ability to use an array of feature files inside config in `gherkin.features`. See #2814 by @jbergeronjr
2935

3036
```js
@@ -33,8 +39,8 @@ Bug fixes:
3339
"./features/api_features/*.feature"
3440
],
3541
```
36-
* Added `getQueueId` to reporter to rerun a specific promise. See #2837 by @jonatask
37-
* **Added `fakerTransform` plugin** to use faker data in Gherkin scenarios. See #2854 by @adrielcodeco
42+
* Added `getQueueId` to reporter to rerun a specific promise. See #2837 by @jonatask
43+
* **Added `fakerTransform` plugin** to use faker data in Gherkin scenarios. See #2854 by @adrielcodeco
3844

3945
```feature
4046
Scenario Outline: ...
@@ -46,17 +52,17 @@ Scenario Outline: ...
4652
| productName | customer | email | anythingMore |
4753
| {{commerce.product}} | Dr. {{name.findName}} | {{internet.email}} | staticData |
4854
```
49-
* [REST] Use class instance of axios, not the global instance, to avoid contaminating global configuration. #2846 by @vanvoljg
55+
* [REST] Use class instance of axios, not the global instance, to avoid contaminating global configuration. #2846 by @vanvoljg
5056
* [Appium] Added `tunnelIdentifier` config option to provide tunnel for SauceLabs. See #2832 by @gurjeetbains
5157

5258
## 3.0.5
5359

5460

5561
Features:
5662

57-
* **[Official Docker image for CodeceptJS v3](https://hub.docker.com/r/codeceptjs/codeceptjs)**. New Docker image is based on official Playwright image and supports Playwright, Puppeteer, WebDriver engines. Thanks @VikentyShevyrin
63+
* **[Official Docker image for CodeceptJS v3](https://hub.docker.com/r/codeceptjs/codeceptjs)**. New Docker image is based on official Playwright image and supports Playwright, Puppeteer, WebDriver engines. Thanks @VikentyShevyrin
5864
* Better support for Typescript `codecept.conf.ts` configuration files. See #2750 by @elaichenkov
59-
* Propagate more events for custom parallel script. See #2796 by @jccguimaraes
65+
* Propagate more events for custom parallel script. See #2796 by @jccguimaraes
6066
* [mocha-junit-reporter] Now supports attachments, see documentation for details. See #2675 by @Shard
6167
* CustomLocators interface for TypeScript to extend from LocatorOrString. See #2798 by @danielrentz
6268
* [REST] Mask sensitive data from log messages.

lib/command/interactive.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ module.exports = async function (path, options) {
1010
process.env.profile = options.profile;
1111
const configFile = options.config;
1212

13-
let config = getConfig(configFile);
13+
const config = getConfig(configFile);
1414
const testsPath = getTestRoot(configFile);
1515

1616
const codecept = new Codecept(config, options);

lib/plugin/screenshotOnFail.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,9 +108,9 @@ module.exports = function (config) {
108108
allureReporter.addAttachment('Last Seen Screenshot', fs.readFileSync(path.join(global.output_dir, fileName)), 'image/png');
109109
}
110110

111-
const cucumberReporter = Container.plugins('cucumberJsonReporter')
112-
if(cucumberReporter){
113-
cucumberReporter.addScreenshot(test.artifacts.screenshot)
111+
const cucumberReporter = Container.plugins('cucumberJsonReporter');
112+
if (cucumberReporter) {
113+
cucumberReporter.addScreenshot(test.artifacts.screenshot);
114114
}
115115
} catch (err) {
116116
output.plugin(err);

0 commit comments

Comments
 (0)