Change unit definition JSON from UTF-8-BOM to UTF-8 #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
Otherways the js JSON parse method returns `SyntaxError: Unexpected token in JSON at position 0` error.
SyntaxError: Unexpected token ] in JSON at position 2871
Codecov Report
@@ Coverage Diff @@
## master #730 +/- ##
=======================================
Coverage 58.56% 58.56%
=======================================
Files 171 171
Lines 38430 38430
=======================================
Hits 22507 22507
Misses 15923 15923Continue to review full report at Codecov.
|
|
This is probably the UTF-8 BOM characters you are seeing. I believe it causes problems on the web, where UTF-8 files are expected to not include the BOM character. I'll try your change and if it doesn't break anything, I think we can merge it in. Will get back to you. |
|
Regenerating code locally does not seem to do any changes except a couple of innocent whitespace changes, so this change should be safe 👍 Famous last words! |
|
Confirmed files are now encoded with utf-8 and not utf-8-bom. |
angularsen
changed the title
|
Thanks! Also, I dig that you made a javascript equivalent. We had an issue #410 on this before, but I never had the time or incentive to put the time into something like that. Very nice! |
haimkastner
added a commit
to haimkastner/unitsnet-js
that referenced
this pull request
Dec 30, 2019
haimkastner
added a commit
to haimkastner/unitsnet-js
that referenced
this pull request
Dec 30, 2019
* Remove local units definitions #2 * Fetch units definitions from the original angularsen unitsnet repo angularsen/UnitsNet#730 #2
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I developed a similar generated library for JavaScript (called unitsnet-js) from those units definition files, the JavaScript JSON parser failed because most of the schemas start with an unknown character.
The unknown character is shown only in the live web version, when I used git to clone the repo, the character has gone (Tested on Windows 10 OS). this why the fix is separated into each file one commit.
This is how it's look in the GitHub web version:
