Skip to content

Commit 96f924a

Browse files
authored
PressureUnit: remove the MeterOfElevation and FootOfElevation (#1531)
- `PressureUnit`: remove the `MeterOfElevation` and `FootOfElevation` - `Pressure`: added `FromElevation` and `ToElevation` methods (using `Length`)
1 parent 5a280b9 commit 96f924a

File tree

11 files changed

+171
-312
lines changed

11 files changed

+171
-312
lines changed

Common/UnitDefinitions/Pressure.json

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -400,30 +400,6 @@
400400
"Abbreviations": [ "inH2O", "inch wc", "wc" ]
401401
}
402402
]
403-
},
404-
{
405-
"SingularName": "MeterOfElevation",
406-
"PluralName": "MetersOfElevation",
407-
"FromUnitToBaseFunc": "Math.Pow(1.0 - ({x} / 44307.69396), 5.2553026003237266401799415610351) * 101325.0",
408-
"FromBaseToUnitFunc": "(1.0 - Math.Pow({x} / 101325.0, 0.190284)) * 44307.69396",
409-
"Localization": [
410-
{
411-
"Culture": "en-US",
412-
"Abbreviations": [ "m of elevation" ]
413-
}
414-
]
415-
},
416-
{
417-
"SingularName": "FootOfElevation",
418-
"PluralName": "FeetOfElevation",
419-
"FromUnitToBaseFunc": "Math.Pow(1.0 - ({x} / 145366.45), 5.2553026003237266401799415610351) * 101325.0",
420-
"FromBaseToUnitFunc": "(1.0 - Math.Pow({x} / 101325.0, 0.190284)) * 145366.45",
421-
"Localization": [
422-
{
423-
"Culture": "en-US",
424-
"Abbreviations": [ "ft of elevation" ]
425-
}
426-
]
427403
}
428404
]
429405
}

UnitsNet.NanoFramework/GeneratedCode/Quantities/Pressure.g.cs

Lines changed: 0 additions & 24 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

UnitsNet.NanoFramework/GeneratedCode/Units/PressureUnit.g.cs

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

UnitsNet.NumberExtensions.Tests/GeneratedCode/NumberToPressureExtensionsTest.g.cs

Lines changed: 0 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

UnitsNet.NumberExtensions/GeneratedCode/NumberToPressureExtensions.g.cs

Lines changed: 0 additions & 22 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

UnitsNet.Tests/CustomCode/PressureTests.cs

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -106,10 +106,6 @@ public class PressureTests : PressureTestsBase
106106

107107
protected override double MillipascalsInOnePascal => 1e3;
108108

109-
protected override double MetersOfElevationInOnePascal => 39364.9129730686;
110-
111-
protected override double FeetOfElevationInOnePascal => 129149.976945763;
112-
113109
[Fact]
114110
public void Absolute_WithAbsolutePressureReference_IsEqual()
115111
{
@@ -283,5 +279,20 @@ public void PressureDividedByTimeSpanEqualsPressureChangeRate()
283279
PressureChangeRate pressureChangeRate = Pressure.FromPascals(50) / TimeSpan.FromSeconds(5);
284280
Assert.Equal(PressureChangeRate.FromPascalsPerSecond(10), pressureChangeRate);
285281
}
282+
283+
[Fact]
284+
public void PressureFromElevation_ConvertsWithRounding()
285+
{
286+
var pressureFromElevation = Pressure.FromElevation(new Length(129149.9769457631, LengthUnit.Foot));
287+
Assert.Equal(1, pressureFromElevation.Pascals, PascalsTolerance);
288+
}
289+
290+
[Fact]
291+
public void ElevationFromPressure_ConvertsWithRounding()
292+
{
293+
Length elevationFromPressure = Pressure.FromPascals(1).ToElevation();
294+
Assert.Equal(LengthUnit.Foot, elevationFromPressure.Unit);
295+
Assert.Equal(129149.976945763, elevationFromPressure.Value, 9);
296+
}
286297
}
287298
}

0 commit comments

Comments
 (0)